Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Allow OnIdiom/OnPlatform to return a Binding #24594

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[C] Allow OnIdiom/OnPlatform to return a Binding #24594

merged 2 commits into from
Sep 10, 2024

Conversation

StephaneDelcroix
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix commented Sep 4, 2024 •
edited
Loading

Description of Change

redirect to SetBinding if SetValue is invoked with a Binding and not targeting a property of type Binding

Issues Fixed

and some others

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner September 4, 2024 14:10
@StephaneDelcroix StephaneDelcroix mentioned this pull request Sep 4, 2024
Closed
@StephaneDelcroix
[C] Allow OnIdiom/OnPlatform to return a Binding
2d899a2 
- fixes #19388
- fixes #18697
- fixes #22877
- closes #23798
- closes #23272

and some others
@rmarinho
Copy link
Member

rmarinho commented Sep 5, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@StephaneDelcroix
fix runtime cast
b36b813 
- fixes #24500
- fixes #16725
@PureWeen PureWeen merged commit 9a78453 into main Sep 10, 2024
97 checks passed
@PureWeen PureWeen deleted the fix_18697_again branch September 10, 2024 15:23
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-9.0.0-rc.2.24503.2
Projects
None yet
Milestone
No milestone
4 participants
@StephaneDelcroix @rmarinho @PureWeen @samhouts