Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the IDE/CLI solution issues #2823

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Oct 4, 2021

Description of Change

Try avoid the conflicts.

Fixes #2746

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@mattleibow mattleibow requested a review from Eilon as a code owner October 4, 2021 13:47
Copy link
Member Author

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this now works with both the CLI and the IDE.

@mattleibow mattleibow requested a review from Redth October 4, 2021 15:55
@Eilon Eilon added the area-templates Project templates, Item Templates for Blazor and MAUI label Oct 4, 2021
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to verify by just looking at it, but assuming you've tested it in each scenario, looks good!

@Redth Redth merged commit cdb68cd into release/6.0.1xx-preview9 Oct 4, 2021
@Redth Redth deleted the dev/fix-sln branch October 4, 2021 19:58
@mattleibow mattleibow added this to the 6.0.101-preview.9 milestone Oct 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants