Remove Forms DeviceInfo and use Essentials #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Eilon
added
the
area-essentials
Redth
approved these changes
Nov 1, 2021
Redth
approved these changes
Nov 2, 2021
conceptdev
added a commit
to conceptdev/maui
that referenced
this pull request
Dec 7, 2021
based on changes in dotnet#3213 where APIs moved to Essentials
37 tasks
PureWeen
added a commit
that referenced
this pull request
Apr 5, 2022
#5020) * initial commit * seems to build? * add page to sample Other > Dual Screen * sample screen tweaks * trying to wire up the hinge angle * correct port of visualElement * - fix up measure calls * correct configChanges in Android sample * - remeasure if mode changed * add AndroidX.Window.WindowJava with log output * kinda measuring but not really * - hostbuilder extension * - include file * basic hostbuilder test * most debug lines to figure out why it's not working * kinda works except on first span :| * add testing features on TwoPaneViewPage * remove un-used UpdateMetrics interface method * remove commented FoldEventArgs * remove un-used UpdateMetrics interface method * deleting code * - remove extra code * [dualscreen] rebase based on changes in #3213 where APIs moved to Essentials * wire up hostbuilder untested * [dualscreen] progress check-in - work not complete * update fixes * [dualscreen] wire up twopaneview properties * [dualscreen] Jetpack Window Manager 1.0 stable via Xamarin.AndroidX.Window.WindowJava NuGet 1.0.0.7 * [dualscreen] add test properties to XAML * [dualscreen] remove MainActivity hardcoding, use HostBuilderExtension Note that this de-coupling broke the hinge sensor reading - to be fixed * [dualscreen] fix hinge sensor requires reference to Activity context * [dualscreen] tweak activity context * [dualscreen] correct for Samsung Galaxy Fold Use the hinge orientation rather than portrait/landscape of the outer window * [dualscreen] refactor project name (remove -net6) * [dualscreen] remove prototyping code from sample project hardcoding in mainactivity helped to get the dualscreen refactoring done, now removed and enabled via HostBuilderExtensions * [dualscreen] add comments * [dualscreen] fix bug: hinge not recognized when spanned on open * [dualscreen] address some of the PR feedback * [dualscreen] rebase fixes mostly Rectangle -> Rect and removing Device.BeginInvokeOnMainThread * [foldable] namespace refactor from DualScreen to Foldable also removed `Controls` from non-UI namespaces * [foldable] refactor project name from DualScreen to Foldable did NOT yet change the project's filesystem/folder name * [foldable] refactor DualScreenService -> FoldableService including IDualScreenService -> IFoldableService * [foldable] refactor filenames DualScreenService -> FoldableService * [foldable] address PR feedback - remove LINQ - use C# 8 feature ??= * - workloads * - cleanup * - delete commented out code * [foldable] remove debug log and commented-out code minor refactor isSeparating -> IsSeparating * [foldable] rename project folder and delete unused sample project/folder * [foldable] remove commented code (PR feedback) * - organize the code a bit and switch to using services * - fix dualscreen service to pull correctly * - cleanup * - fix update calls * - fix some measures * - add some additional checks * - remove screen check * - fix height passed in for mode updates * - remove watch for changes * - remove code that checks * - fix workloads * - workloads * - fix paths * - fix nuget.config * Update Microsoft.Maui.Controls.Foldable.Runtime.csproj * Update Microsoft.Maui.Controls.Ref.csproj * - change controls workloads back * - remove from workloads * - add foldable to build.tasks * Update Microsoft.Maui.Samples.slnf * - leave foldables * [foldable] update namespaces after Essentials * [foldable] add Devices where Essentials was removed Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
samhouts
added
the
fixed-in-6.0.101-preview.11.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove usage of the internal/hidden DeviceInfo and use the APIs in Essentials.
Part of #1965
Additions made
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.