Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix issue not rendering Border if Background is null #3588

Merged
merged 1 commit into from
Nov 30, 2021
Merged

[Windows] Fix issue not rendering Border if Background is null #3588

merged 1 commit into from
Nov 30, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue not rendering Border if Background is null on Windows.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing labels Nov 30, 2021
@rmarinho rmarinho merged commit 664bc35 into main Nov 30, 2021
@rmarinho rmarinho deleted the fix-3349 branch November 30, 2021 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Border throws with a shape of Rectangle
2 participants
@jsuarezruiz @rmarinho