Implement Padding in ILabel Handlers #421

hartez · 2021-03-04T20:04:10Z

Implements #369

Adds Thickness Padding { get; } to the ILabel interface
Adds Padding property map to LabelHandler
Adds Padding mapping methods to LabelHandler for Android and iOS
Adds extension methods to apply Padding on Android/iOS
Adds UILabel subclass MauiLabel (to support Padding, since UILabel doesn't by default)
Adds DeviceTests for initial Padding values on iOS and Android

Fixes #369

hartez · 2021-03-04T20:08:41Z

src/Controls/samples/Controls.Sample/Pages/MainPage.cs

@@ -33,6 +33,7 @@ void SetupMauiLayout()
 			verticalStack.Add(new Label { Text = "This should be BIG text!", FontSize = 24 });
 			verticalStack.Add(new Label { Text = "This should be BOLD text!", FontAttributes = FontAttributes.Bold });
 			verticalStack.Add(new Label { Text = "This should be a CUSTOM font!", FontFamily = "Dokdo" });
+			verticalStack.Add(new Label { Text = "This should have padding", Padding = new Thickness(40), BackgroundColor = Color.LightBlue });


Adds an example of the property to the sample project.

hartez · 2021-03-04T20:09:03Z

src/Core/src/Core/ILabel.cs

@@ -2,5 +2,6 @@ namespace Microsoft.Maui
 {
 	public interface ILabel : IView, IText, IFont
 	{
+		Thickness Padding { get; }


Adds the property to the interface.

hartez · 2021-03-04T20:09:39Z

src/Core/src/Handlers/Label/LabelHandler.Android.cs

+		{
+			handler.TypedNativeView?.UpdatePadding(label);
+		}
+


Add a mapping method to the Android aspect of the handler.

hartez · 2021-03-04T20:10:06Z

src/Core/src/Handlers/Label/LabelHandler.Standard.cs

@@ -11,5 +11,6 @@ public partial class LabelHandler : AbstractViewHandler<ILabel, object>
 		public static void MapFontFamily(LabelHandler handler, ILabel label) { }
 		public static void MapFontSize(LabelHandler handler, ILabel label) { }
 		public static void MapFontAttributes(LabelHandler handler, ILabel label) { }
+		public static void MapPadding(LabelHandler handler, ILabel label) {	}


Add a mapping method to the Standard aspect of the handler; the Standard aspect is just a placeholder and is never actually called.

hartez · 2021-03-04T20:10:35Z

src/Core/src/Handlers/Label/LabelHandler.cs

@@ -9,6 +9,7 @@ public partial class LabelHandler
 			[nameof(ILabel.FontFamily)] = MapFontFamily,
 			[nameof(ILabel.FontSize)] = MapFontSize,
 			[nameof(ILabel.FontAttributes)] = MapFontAttributes,
+			[nameof(ILabel.Padding)] = MapPadding,


Add the mapping to the PropertyMapper for the handler.

hartez · 2021-03-04T20:10:53Z

src/Core/src/Handlers/Label/LabelHandler.iOS.cs

+		{
+			handler.TypedNativeView?.UpdatePadding(label);
+		}
+


Add a mapping method to the iOS aspect of the handler.

hartez · 2021-03-04T20:11:54Z

src/Core/src/Platform/Android/LabelExtensions.cs

+					(int)context.ToPixels(label.Padding.Top),
+					(int)context.ToPixels(label.Padding.Right),
+					(int)context.ToPixels(label.Padding.Bottom));
+		}


Add an extension method to handle the actual update for the native Android control. This logic is ported directly from the Forms Label renderer for Android.

hartez · 2021-03-04T20:12:26Z

src/Core/src/Platform/Standard/LabelExtensions.cs

+		public static void UpdatePadding(this object nothing, ILabel label)
+		{ 
+
+		}


The placeholder extension method for Standard; this is never actually called.

hartez · 2021-03-04T20:12:41Z

src/Core/src/Platform/iOS/LabelExtensions.cs

+					(float)label.Padding.Bottom,
+					(float)label.Padding.Right);
+
+		}


Add an extension method to handle the actual update for the native iOS control. This logic is ported directly from the Forms Label renderer for iOS.

hartez · 2021-03-04T20:13:51Z

src/Core/src/Platform/iOS/MauiLabel.cs

+			width: size.Width + TextInsets.Left + TextInsets.Right,
+			height: size.Height + TextInsets.Top + TextInsets.Bottom);
+	}
+}


For this particular property, we needed to extend the UILabel class with some custom logic because Padding doesn't exist natively. This class was ported from the Forms iOS platform project.

hartez · 2021-03-04T20:15:05Z

src/Core/tests/DeviceTests/Handlers/Label/LabelHandlerTests.Android.cs

+			Assert.Equal(expectedRight, right);
+			Assert.Equal(expectedBottom, bottom);
+		}
+


Adds an on-device test to verify that the property is being set on the native Android control. This test will be run on an Android device as part of the CI process.

hartez · 2021-03-04T20:15:35Z

src/Core/tests/DeviceTests/Handlers/Label/LabelHandlerTests.iOS.cs

+			Assert.Equal(15, insets.Right);
+			Assert.Equal(20, insets.Bottom);
+		}
+


Adds an on-device test to verify that the property is being set on the native iOS control. This test will be run on an iOS device as part of the CI process.

hartez · 2021-03-04T20:16:29Z

src/Core/tests/DeviceTests/Stubs/LabelStub.cs

@@ -11,5 +11,7 @@ public partial class LabelStub : StubBase, ILabel
 		public string FontFamily { get; set; }

 		public double FontSize { get; set; }
+
+		public Thickness Padding { get; set; }


The stub classes are implementations of the MAUI interfaces used for on-device testing.

hartez added 2 commits March 4, 2021 12:59

Implement Padding handlers for ILabel

6780871

Fixes #369

Add example to Controls.Sample

35591a1

hartez commented Mar 4, 2021

View reviewed changes

Merge branch 'main' into fix-369

b857b49

mattleibow approved these changes Mar 5, 2021

View reviewed changes

mattleibow and others added 2 commits March 5, 2021 03:56

Merge branch 'main' into fix-369

08fcc2a

Merge branch 'main' into fix-369

c2bc3f0

jsuarezruiz approved these changes Mar 5, 2021

View reviewed changes

Merge branch 'main' into fix-369

b610353

mattleibow merged commit 700d81b into main Mar 5, 2021

mattleibow deleted the fix-369 branch March 5, 2021 21:00

samhouts added area-controls-label Label, Span platform/android 🤖 platform/iOS 🍎 labels Jul 10, 2023

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023

github-actions bot locked and limited conversation to collaborators Dec 27, 2023

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Padding in ILabel Handlers #421

Implement Padding in ILabel Handlers #421

hartez commented Mar 4, 2021 •

edited

Loading

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

hartez Mar 4, 2021

Implement Padding in ILabel Handlers #421

Implement Padding in ILabel Handlers #421

Conversation

hartez commented Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hartez commented Mar 4, 2021 •

edited

Loading