Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DeviceInfo to use an interface #4465

Merged
merged 6 commits into from
Feb 6, 2022
Merged

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Feb 2, 2022

Description of Change

Use a lazy interface.

Required for #1965

Additions made

public interface IDeviceInfo
{
	string Model { get; }
	string Manufacturer { get; }
	string Name { get; }
	string VersionString { get; }
	Version Version { get; }
	DevicePlatform Platform { get; }
	DeviceIdiom Idiom { get; }
	DeviceType DeviceType { get; }
}

@mattleibow mattleibow self-assigned this Feb 2, 2022
@mattleibow mattleibow added this to the 6.0.300-preview.14 milestone Feb 2, 2022
@mattleibow mattleibow added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Feb 3, 2022
@mattleibow mattleibow requested a review from Redth February 3, 2022 20:07
{
partial class DeviceDisplayImplementation : IDeviceDisplay
public class DeviceDisplayImplementation : IDeviceDisplay
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the files to match the classes?

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Does it make sense to rename the files to match the classes?

@mattleibow mattleibow merged commit 97d4553 into main Feb 6, 2022
@mattleibow mattleibow deleted the dev/essentials-deviceinfo branch February 6, 2022 03:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2!
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants