Make Device.Idiom and Device.RuntimePlatform use Essentials #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
the
legacy-area-controls
mattleibow
commented
Feb 7, 2022
Comment on lines
+35
to
+52
| public static TargetIdiom Idiom | ||
| { | ||
| get | ||
| { | ||
| var idiom = DeviceInfo.Idiom; | ||
| if (idiom == DeviceIdiom.Tablet) | ||
| return TargetIdiom.Tablet; | ||
| if (idiom == DeviceIdiom.Phone) | ||
| return TargetIdiom.Phone; | ||
| if (idiom == DeviceIdiom.Desktop) | ||
| return TargetIdiom.Desktop; | ||
| if (idiom == DeviceIdiom.TV) | ||
| return TargetIdiom.TV; | ||
| if (idiom == DeviceIdiom.Watch) | ||
| return TargetIdiom.Watch; | ||
| return TargetIdiom.Unsupported; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is technically not very extensible, but in reality, this API needs to be obsoleted. I'll do that in another PR because that will involve many code changes. #4549
27 tasks
mattleibow
changed the title
mattleibow
commented
Feb 8, 2022
| @@ -152,7 +152,6 @@ Task("dotnet-test") | |||
| "**/Core.UnitTests.csproj", | |||
| "**/Essentials.UnitTests.csproj", | |||
| "**/Resizetizer.UnitTests.csproj", | |||
| "**/Controls.Sample.Tests.csproj" | |||
There was a problem hiding this comment.
Moved these tests into Controls.Core.UnitTests.csproj since that is all it really was.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hartez
approved these changes
Feb 8, 2022
2 tasks
This was referenced Mar 22, 2022
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR makes the
Device.Idiomproperty get the value from Essentials instead ofIPlatformServices.Swapping out of this feature for testing can now be done in essentials using the
DeviceInfo.SetCurrent(IDeviceInfo)member.Additions made
Device.SetIdiomandDevice.SetTargetIdiomIPlatformServices.RuntimePlatformDevice.Idiomnow just returnsDeviceInfo.IdiomDevice.RuntimePlatformnow just returnsDeviceInfo.PlatformMockDeviceInfofor unit testingPR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.