[Essentials] Fix maciOS version checks #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 158ffbd accidentially introduced what was likely a breaking change in `Platform.ios.tvos.watchos.HasOSVersion`. The call to `UIDevice.CurrentDevice.CheckSystemVersion` was replaced by `OperatingSystem.IsIOSVersionAtLeast`, however `HasOSVersion` was used on platforms other than iOS. Fix this oversight by removing `HasOSVersion` entirely, and use the correct `Is$(Platform)VersionAtLeast` variant at all call sites instead. `OperatingSystem.IsIOSVersionAtLeast` will work on iOS and MacCatalyst, but not on tvOS. Additional tvOS checks have been added as needed. Instances of `DeviceInfo.Version` have also been replaced by `Is$(Platform)VersionAtLeast` where applicable.
pjcollins
force-pushed
the
essentials-macios-version-fix
branch
from
03347c9
to
2ca2834
Compare
Eilon
added
the
area-essentials
Redth
approved these changes
Feb 25, 2022
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #461
Commit 158ffbd accidentially introduced what was likely a breaking
change in
Platform.ios.tvos.watchos.HasOSVersion. The call toUIDevice.CurrentDevice.CheckSystemVersionwas replaced byOperatingSystem.IsIOSVersionAtLeast, howeverHasOSVersionwas usedon platforms other than iOS.
Fix this oversight by removing
HasOSVersionentirely, and use thecorrect
Is$(Platform)VersionAtLeastvariant at all call sites instead.OperatingSystem.IsIOSVersionAtLeastwill work on iOS and MacCatalyst,but not on tvOS. Additional tvOS checks have been added as needed.
Instances of
DeviceInfo.Versionhave also been replaced byIs$(Platform)VersionAtLeastwhere applicable.