IBorder now works again for iOS/Android #4909
Conversation
There was a problem hiding this comment.
Seems good to me, but then @jsuarezruiz is probably more of an expert.
| BringSubviewToFront(BorderView); | ||
| BorderView.Frame = Bounds; |
There was a problem hiding this comment.
We no longer need to bring it to front? @jsuarezruiz?
There was a problem hiding this comment.
Tried and is not necessary. Is already done in other place.
|
We were bringing it to the front twice, instead of setting the frame. So I changed one to frame. I think it was a bad merge. |
| @@ -5,6 +5,26 @@ namespace Microsoft.Maui.Platform | |||
| { | |||
| public static class StrokeExtensions | |||
| { | |||
| public static void UpdateBorderStroke(this AView platformView, IBorderStroke border) | |||
There was a problem hiding this comment.
Do Windows require changes too?
There was a problem hiding this comment.
Maybe? Was traveling without a windows machine. Was going to check tomorrow.
There was a problem hiding this comment.
Yes, taking a look to WrapperView on Windows the logic to manage the border is missing. I think we should use the BorderChanged method to detect changes and ContentPanel control instead Grid in the WrapperView.
There was a problem hiding this comment.
I will send another PR with the Windows implementation. In that way we can merge and not block this PR.
| BringSubviewToFront(BorderView); | ||
| BorderView.Frame = Bounds; |
There was a problem hiding this comment.
Tried and is not necessary. Is already done in other place.
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
|
@PureWeen looks my suggestion was wrong :( I didn't know why since there is a check for null right before |
|
@pictos oh yea it's an |
Silly me >.< |
On iOS, the overlay view never had it's frame set.
On Android, we were not calling all the correct properties, if it's only an iBorder