Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IImageSourceServiceConfiguration #4954

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Remove IImageSourceServiceConfiguration #4954

merged 2 commits into from
Feb 28, 2022

Conversation

mattleibow
Copy link
Member

Description of Change

This was a hack around a hack. We need to rethinks this entirely, but for RC we cannot have this. Rather have no code than terrible hack code.

Fixes #886

Additions made

  • Removes IImageSourceServiceConfiguration and all related code

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

This was a hack around a hack
@mattleibow mattleibow self-assigned this Feb 27, 2022
@mattleibow mattleibow added the area-image Image loading, sources, caching label Feb 27, 2022
@mattleibow mattleibow added this to the 6.0.300-preview.14 milestone Feb 27, 2022
@Redth Redth merged commit 7165e52 into main Feb 28, 2022
@Redth Redth deleted the dev/remove-iissc branch February 28, 2022 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon added area-controls-image Image control and removed area-image Image loading, sources, caching labels May 10, 2024
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-image Image control fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2!
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] The Windows ImageDirectory property is weird and not very user-friendly
4 participants