Using the Controls Application

src/Compatibility/ControlGallery/src/Android/CustomRenderers.cs

@@ -264,10 +264,7 @@ public NativeListViewRenderer(Context context) : base(context)
 
 		protected override global::Android.Widget.ListView CreateNativeControl()
 		{
-#pragma warning disable 618
-			// Disabled the warning so we have a test that this obsolete stuff still works
-			return new global::Android.Widget.ListView(Forms.Context);
-#pragma warning restore 618
+			return new global::Android.Widget.ListView(Context);
 		}
 
 		protected override void OnElementChanged(ElementChangedEventArgs<NativeListView> e)
@@ -289,10 +286,7 @@ protected override void OnElementChanged(ElementChangedEventArgs<NativeListView>
 			{
 				// subscribe
 
-#pragma warning disable 618
-				// Disabled the warning so we have a test that this obsolete stuff still works
-				Control.Adapter = new NativeListViewAdapter(Forms.Context.GetActivity(), e.NewElement);
-#pragma warning restore 618
+				Control.Adapter = new NativeListViewAdapter(Context.GetActivity(), e.NewElement);
 				Control.ItemClick += Clicked;
 			}
 		}
@@ -309,10 +303,7 @@ protected override void OnElementPropertyChanged(object sender, System.Component
 			{
 				// update the Items list in the UITableViewSource
 
-#pragma warning disable 618
-				// Disabled the warning so we have a test that this obsolete stuff still works
-				Control.Adapter = new NativeListViewAdapter(Forms.Context.GetActivity(), Element);
-#pragma warning restore 618
+				Control.Adapter = new NativeListViewAdapter(Context.GetActivity(), Element);
 			}
 		}
 	}
@@ -471,10 +462,7 @@ protected override void OnElementChanged(ElementChangedEventArgs<NativeListView2
 			if (e.NewElement != null)
 			{
 				// subscribe
-#pragma warning disable 618
-				// Disabled the warning so we have a test that this obsolete stuff still works
-				Control.Adapter = new NativeAndroidListViewAdapter(Forms.Context.GetActivity(), e.NewElement);
-#pragma warning restore 618
+				Control.Adapter = new NativeAndroidListViewAdapter(Context.GetActivity(), e.NewElement);
 				Control.ItemClick += Clicked;
 			}
 		}
@@ -496,10 +484,7 @@ protected override void OnElementPropertyChanged(object sender, System.Component
 			{
 				// update the Items list in the UITableViewSource
 
-#pragma warning disable 618
-				// Disabled the warning so we have a test that this obsolete stuff still works
-				Control.Adapter = new NativeAndroidListViewAdapter(Forms.Context.GetActivity(), Element);
-#pragma warning restore 618
+				Control.Adapter = new NativeAndroidListViewAdapter(Context.GetActivity(), Element);
 			}
 		}
 	}

src/Compatibility/Core/src/Android/ColorExtensions.cs

@@ -16,18 +16,6 @@ public static AColor ToAndroid(this Color self)
 			return new AColor((byte)(byte.MaxValue * self.R), (byte)(byte.MaxValue * self.G), (byte)(byte.MaxValue * self.B), (byte)(byte.MaxValue * self.A));
 		}
 
-		[Obsolete("ToAndroid(this Color, int) is obsolete as of version 2.5. Please use ToAndroid(this Color, int, Context) instead.")]
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		public static AColor ToAndroid(this Color self, int defaultColorResourceId)
-		{
-			if (self == Color.Default)
-			{
-				return new AColor(ContextCompat.GetColor(Forms.Context, defaultColorResourceId));
-			}
-
-			return ToAndroid(self);
-		}
-
 		public static AColor ToAndroid(this Color self, int defaultColorResourceId, Context context)
 		{
 			if (self == Color.Default)

src/Compatibility/Core/src/Android/Forms.cs

@@ -62,12 +62,8 @@ public static class Forms
 		static bool? s_isPieOrNewer;
 		static FontManager s_fontManager;
 
-		[Obsolete("Context is obsolete as of version 2.5. Please use a local context instead.")]
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		public static Context Context { get; internal set; }
-
 		// One per process; does not change, suitable for loading resources (e.g., ResourceProvider)
-		internal static Context ApplicationContext { get; private set; }
+		internal static Context ApplicationContext { get; private set; } = global::Android.App.Application.Context;
 		internal static IMauiContext MauiContext { get; private set; }
 
 		public static bool IsInitialized { get; private set; }
@@ -232,30 +228,6 @@ public static void Init(InitializationOptions options)
 			Profile.FrameEnd();
 		}
 
-		/// <summary>
-		/// Sets title bar visibility programmatically. Must be called after Microsoft.Maui.Controls.Compatibility.Forms.Init() method
-		/// </summary>
-		/// <param name="visibility">Title bar visibility enum</param>
-		[Obsolete("SetTitleBarVisibility(AndroidTitleBarVisibility) is obsolete as of version 2.5. "
-			+ "Please use SetTitleBarVisibility(Activity, AndroidTitleBarVisibility) instead.")]
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		public static void SetTitleBarVisibility(AndroidTitleBarVisibility visibility)
-		{
-			if (Context.GetActivity() == null)
-				throw new NullReferenceException("Must be called after Microsoft.Maui.Controls.Compatibility.Forms.Init() method");
-
-			if (visibility == AndroidTitleBarVisibility.Never)
-			{
-				if (!Context.GetActivity().Window.Attributes.Flags.HasFlag(WindowManagerFlags.Fullscreen))
-					Context.GetActivity().Window.AddFlags(WindowManagerFlags.Fullscreen);
-			}
-			else
-			{
-				if (Context.GetActivity().Window.Attributes.Flags.HasFlag(WindowManagerFlags.Fullscreen))
-					Context.GetActivity().Window.ClearFlags(WindowManagerFlags.Fullscreen);
-			}
-		}
-
 		public static void SetTitleBarVisibility(Activity activity, AndroidTitleBarVisibility visibility)
 		{
 			if (visibility == AndroidTitleBarVisibility.Never)
@@ -358,16 +330,10 @@ static void SetupInit(
 			var activity = context.Context;
 			Profile.FrameBegin();
 			Registrar.RegisterRendererToHandlerShim(RendererToHandlerShim.CreateShim);
-			if (!IsInitialized)
-			{
-				// Only need to get this once; it won't change
-				ApplicationContext = activity.ApplicationContext;
-				MauiContext = context;
-			}
 
-#pragma warning disable 618 // Still have to set this up so obsolete code can function
-			Context = activity;
-#pragma warning restore 618
+			// Allow this multiple times to support the app and then the activity
+			ApplicationContext = activity.ApplicationContext;
+			MauiContext = context;
 
 			if (!IsInitialized)
 			{
@@ -418,7 +384,8 @@ static void SetupInit(
 
 			Profile.FramePartition("RegisterAll");
 
-			RegisterCompatRenderers(maybeOptions);
+			if (maybeOptions?.Flags.HasFlag(InitializationFlags.SkipRenderers) != true)
+				RegisterCompatRenderers(maybeOptions);
 
 			Profile.FramePartition("Epilog");
 

src/Compatibility/Core/src/Android/ResourceManager.cs

@@ -321,29 +321,6 @@ public static Task<Bitmap> GetBitmapAsync(this Resources resource, string name,
 			return BitmapFactory.DecodeResourceAsync(resource, IdFromTitle(name, DrawableClass, _drawableDefType, resource, context.PackageName));
 		}
 
-		[Obsolete("GetDrawable(this Resources, string) is obsolete as of version 2.5. "
-			+ "Please use GetDrawable(this Context, string) instead.")]
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		public static Drawable GetDrawable(this Resources resource, string name)
-		{
-			int id = IdFromTitle(name, DrawableClass, _drawableDefType, resource);
-			if (id == 0)
-			{
-				Log.Warning("Could not load image named: {0}", name);
-				return null;
-			}
-
-			return AndroidAppCompat.GetDrawable(Forms.Context, id);
-		}
-
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		static void LogInfoToPreviewer(string message)
-		{
-			Java.Lang.Class designerHost = Java.Lang.Class.FromType(typeof(ImageRenderer)).ClassLoader.LoadClass("mono.android.HostProcessConnection");
-			Java.Lang.Reflect.Method reportMethod = designerHost.GetMethod("logInfo", Java.Lang.Class.FromType(typeof(Java.Lang.String)));
-			reportMethod.Invoke(null, message);
-		}
-
 		public static Drawable GetDrawable(this Context context, string name)
 		{
 			int id = IdFromTitle(name, DrawableClass, _drawableDefType, context);
@@ -362,44 +339,16 @@ public static int GetDrawableId(this Context context, string title)
 			return IdFromTitle(title, DrawableClass, _drawableDefType, context);
 		}
 
-		[Obsolete("GetDrawableByName(string) is obsolete as of version 4.8. "
-			+ "Please use GetDrawableId(string, context) instead.")]
-		public static int GetDrawableByName(string name)
-		{
-			return IdFromTitle(name, DrawableClass, _drawableDefType, Forms.ApplicationContext);
-		}
-
-		[Obsolete("GetResourceByName(string) is obsolete as of version 4.8. "
-			+ "Please use GetResource(string, context) instead.")]
-		public static int GetResourceByName(string name)
-		{
-			return IdFromTitle(name, ResourceClass, "id", Forms.ApplicationContext);
-		}
-
 		public static int GetResource(this Context context, string title)
 		{
 			return IdFromTitle(title, ResourceClass, "id", context);
 		}
 
-		[Obsolete("GetLayoutByName(string) is obsolete as of version 4.8. "
-			+ "Please use GetLayout(string, context) instead.")]
-		public static int GetLayoutByName(string name)
-		{
-			return IdFromTitle(name, LayoutClass, "layout", Forms.ApplicationContext);
-		}
-
 		public static int GetLayout(this Context context, string name)
 		{
 			return IdFromTitle(name, LayoutClass, "layout", context);
 		}
 
-		[Obsolete("GetStyleByName(string) is obsolete as of version 4.8. "
-			+ "Please use GetStyle(string, context) instead.")]
-		public static int GetStyleByName(string name)
-		{
-			return IdFromTitle(name, StyleClass, "style", Forms.ApplicationContext);
-		}
-
 		public static int GetStyle(this Context context, string name)
 		{
 			return IdFromTitle(name, StyleClass, "style", context);

src/Compatibility/Core/src/AppHostBuilderExtensions.cs

@@ -6,6 +6,21 @@ namespace Microsoft.Maui.Controls.Compatibility
 {
 	public static class AppHostBuilderExtensions
 	{
+		public static IAppHostBuilder RegisterCompatibilityForms(this IAppHostBuilder builder)
+		{
+#if __ANDROID__
+			var options = new InitializationOptions(global::Android.App.Application.Context, null, null);
+#elif __IOS__
+			var options = new InitializationOptions();
+#endif
+
+			options.Flags |= InitializationFlags.SkipRenderers;
+
+			Forms.Init(options);
+
+			return builder;
+		}
+
 		public static IAppHostBuilder RegisterCompatibilityRenderers(this IAppHostBuilder builder)
 		{
 			// This won't really be a thing once we have all the handlers built