Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Renaming APIs Native to Platform #6643

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

rookiejava
Copy link
Contributor

Description of Change

According to naming rule of .NET MAUI project, I've replaced all instances of 'Native' to 'Platform' in Tizen backend.
For more background on this change, see #4451.

@rookiejava rookiejava requested a review from a team as a code owner April 29, 2022 04:13
public EvasObject NativeParent => MauiContext?.GetNativeParent() ?? throw new InvalidOperationException($"NativeParent cannot be null here");
public EvasObject PlatformParent => MauiContext?.GetPlatformParent() ?? throw new InvalidOperationException($"PlatformParent cannot be null here");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the only breaking change but it should be ok because I am not sure we have that many Maui Tizen libs just yet since we just released RC with this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of other similar properties, but they are protected and on Shell things. Even less likely to be hit.

@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho rmarinho merged commit 62087e0 into dotnet:main Apr 29, 2022
@rookiejava rookiejava deleted the rename-native-tizen branch April 29, 2022 10:57
@samhouts samhouts added the platform/tizen Samsung Tizen Devices (TV) label Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! platform/tizen Samsung Tizen Devices (TV)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants