iOS modals use Window.ModalNavigationManager vs Application.NavigationProxy
#6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
platform/iOS 🍎
area-controls-modal
area-controls-dialogalert
|
Need to do some additional testing on Shell specifically. |
# Conflicts: # src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.iOS.cs
PureWeen
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR does two things:
The
Application.NavigationProxydoes not get set anymore as per this change, which caused theNavigationProxyto benullin this scenario.Issues Fixed
Fixes #6666