Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Date/Time Pickers on Android only pop up when tapped/clicked/enter key hit #8913

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Jul 21, 2022

Description of Change

Removes auto-open on focus from Date/Time Pickers, sets FocusableInTouchMode to false so that they open on the first tap.

Issues Fixed

  • Single pickers on pages auto-opening when the page is navigated to

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jsuarezruiz jsuarezruiz added the area-controls-datetimepicker DatePicker, TimePicker label Jul 22, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 22, 2022
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a different behavior with respect to Xamarin.Forms?

{
base.OnFocusChanged(gainFocus, direction, previouslyFocusedRect);

if (gainFocus)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix #8130

Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@gerhartz
Copy link

I think this PR broke the ability to open a TimePicker in code. .Focus() was the way to open a picker but now that is broken.

How are you able to open a Timepicker from C#?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added fixed-in-7.0.0-rc.1.6683 fixed-in-6.0.486 Look for this fix in 6.0.486 SR4! labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-datetimepicker DatePicker, TimePicker fixed-in-6.0.486 Look for this fix in 6.0.486 SR4! fixed-in-7.0.0-rc.1.6683
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants