-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Date/Time Pickers on Android only pop up when tapped/clicked/enter key hit #8913
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be a different behavior with respect to Xamarin.Forms?
{ | ||
base.OnFocusChanged(gainFocus, direction, previouslyFocusedRect); | ||
|
||
if (gainFocus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fix #8130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
I think this PR broke the ability to open a TimePicker in code. .Focus() was the way to open a picker but now that is broken. How are you able to open a Timepicker from C#? |
Description of Change
Removes auto-open on focus from Date/Time Pickers, sets
FocusableInTouchMode
tofalse
so that they open on the first tap.Issues Fixed