Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test in multiple terminal emulators #8413

Closed
15 of 16 tasks
Tracked by #8370
rainersigwald opened this issue Feb 7, 2023 · 3 comments
Closed
15 of 16 tasks
Tracked by #8370

Test in multiple terminal emulators #8413

rainersigwald opened this issue Feb 7, 2023 · 3 comments
Assignees
@rokonec
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Iteration:2023April size:2 triaged

Comments

@rainersigwald
Copy link
Member

rainersigwald commented Feb 7, 2023 •
edited by rokonec
Loading

  • VS Code Windows
    • Opens file in VS as oppose to containing folder, but this seems to me as correct behavior... same as Linux below. But it might not work with relative file paths. Needs to be retested after implementation.
  • VS Code Mac
    • Opens file in VS as oppose to containing folder, but this seems to me as correct behavior... same as Linux below.
  • VS Code Linux
    • Opens file in VS as oppose to containing folder, but this seems to me as correct behavior...
      image
  • macOS Terminal - can't interact with hyperlinks
  • macOS iTerm2
    • Can interact with hyperlinks, but shows error:
      image
  • macOS Warp
  • Linux
    • Default ubuntu 22 term - fully working
    • Konsole - can't interact with hyperlinks
    • Tilda - can't interact with hyperlinks
    • XTerm - can't interact with hyperlinks
    • Xfce - can't interact with hyperlinks
    • Terminus - can't interact with hyperlinks
    • Terminator - fully working
    • MATE - can't interact with hyperlinks
    • Manjaro default console (zsh Konsole) - can't interact with hyperlinks
@rainersigwald rainersigwald mentioned this issue Feb 7, 2023
Open
28 tasks
@edvilme
Copy link
Member

edvilme commented Feb 7, 2023

I can confirm it works well on macOS iTerm.
Works well on macOS Terminal, but ansi sequences for hyperlinks are not supported (but we have our fallback ie showing the path)

@rokonec rokonec mentioned this issue Apr 21, 2023
Merged
JaynieBai pushed a commit that referenced this issue Apr 24, 2023
@rokonec
Fix outputIsScreen on non-windows OS. (#8689)
c6e6cd4 
Detected while working on #8413

Context
outputIsScreen is always falls on on non-windows OS causing /tl:auto to reject live logger

Changes Made
see files

Testing
locally

Notes
would affect MSB server VT100 output coloring as well.
@rokonec rokonec mentioned this issue Apr 25, 2023
Merged
@reflectronic
Copy link

reflectronic commented Apr 29, 2023 •
edited
Loading

Unfortunately, on Windows 10, the emoji show up as tofu in the legacy console host:
LiveLogger build output, with tofu in place of emojis

In Windows 11, conhost supports font fallback, so they appear to work fine. (Simulated by downloading the latest version of the console host from the Terminal repo:)
LiveLogger build output, but with emoji displaying properly

And you can work around it by setting HKEY_CURRENT_USER\Console\UseDx to 1 (use at your own risk and so on):
LiveLogger build output, but with emoji displaying properly, now in full color

@ladipro ladipro added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label May 2, 2023
@ladipro ladipro mentioned this issue May 2, 2023
Closed
@ladipro
Copy link
Member

ladipro commented May 2, 2023

@reflectronic thank you! I've filed #8723 to track the Win10 bug.

@ladipro ladipro closed this as completed May 2, 2023
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rokonec rokonec

Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Iteration:2023April size:2 triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rainersigwald @edvilme @ladipro @rokonec @reflectronic @AR-May