Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binlog redacting - properly process embedded files #9147

Closed
Tracked by #8400 ...
JanKrivanek opened this issue Aug 21, 2023 · 3 comments · Fixed by #9307
Closed
Tracked by #8400 ...

Binlog redacting - properly process embedded files #9147

JanKrivanek opened this issue Aug 21, 2023 · 3 comments · Fixed by #9307

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Aug 21, 2023

Context

#8400
Prototype was created: https://github.com/JanKrivanek/MSBuildBinlogRedactor (it currently needs a private MSBuild nuget - as the exposed MSBuild api is not yet merged)
The prototype properly replies the binary events - it however doesn't care about the embadded files.

Goal

All supplemental content of the original binlog (embedded files, anything else?) is copied over to target binlog file aftery replying.
This should eas well work when post-processing (replying) binlog that was produced on a different machine.
Nice to have - the embadded files are as well processed as text data and scanned for sensitive data occurence.

@JanKrivanek
Copy link
Member Author

Setup:

@JanKrivanek
Copy link
Member Author

The proposal fix for this is done in the redactor repo: dotutils/MSBuild.BinlogRedactor#2

It requires changes in MSBuild repo - proposed in #9219, untill those are accepted the work cannot be considered done.

Alternative approach is implementation whole functionality in separate repo (this option will be approached as well - via contribution to binlog viewer, as it has potential for quicker and lower-risk piloting and feedback on changes)

@JanKrivanek
Copy link
Member Author

Near completition. PR: #9307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment