Enable clean + build of crosstargeting projects #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a better long-term fix than NuGet/NuGet.Client#1167, but it affects all multi-targeting SDK-using projects, rather than just consumers of |
nguerrera
approved these changes
Feb 2, 2017
|
@nguerrera Thoughts on risk for this fix (which also does |
nguerrera
reviewed
Feb 2, 2017
cdmihai
approved these changes
Feb 3, 2017
|
Retargeted to xplat based on the decision today to not take this for RTW. @dotnet-bot test this please |
|
Are we taking the nuget workaround for rtm ? |
|
My understanding was that we would do neither for RTW.
|
|
for rtm, we've decided we will live without either. happy to discuss tomorrow. |
Fixes dotnet#1065 by duplicating `DispatchToInnerBuilds` to the crosstargeting version of `Clean`. This enables Clean to run before Build (or the arbitrary user target set via the `InnerTargets` property), reducing the surprise of command line builds that use `/t:Clean;Build` rather than `/t:Rebuild`. This change also changes the cross-targeting definition of `Rebuild` to match the standard `Clean;Build` rather than invoking `Rebuild` on each inner build. That makes it easier to author outer-build extension logic, fixing NuGet/Home#4475.
rainersigwald
force-pushed
the
crosstargeting-clean-and-build
branch
from
a718103
to
36b9ced
Compare
AndyGerlicher
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065 by duplicating
DispatchToInnerBuildsto the crosstargetingversion of
Clean. This enables Clean to run before Build (or thearbitrary user target set via the
InnerTargetsproperty), reducing thesurprise of command line builds that use
/t:Clean;Buildrather than/t:Rebuild.This change also changes the cross-targeting definition of
Rebuildtomatch the standard
Clean;Buildrather than invokingRebuildon eachinner build. That makes it easier to author outer-build extension logic,
fixing NuGet/Home#4475.