Suggestion to parse solution when projects have similar names #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirmal4G
reviewed
May 22, 2020
|
What's wrong with this: |
As far as I know, the unique name is based on the project name, not the file name. |
Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
There was a problem hiding this comment.
Thanks @joseotavioq! This is looking pretty good. Would you like to mark it ready for review?
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
…m/joseotavioq/msbuild into fix_sln_parser_proj_similar_names
Forgind
approved these changes
Aug 12, 2020
Changing comments Co-authored-by: Forgind <Forgind@users.noreply.github.com>
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
|
Thanks for your work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a fix to detect collision caused by a unique project name's normalization, reported on issue #3019