Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console logger support for IncludeEvaluationPropertiesAndItems #6535

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Console logger support for IncludeEvaluationPropertiesAndItems #6535

merged 4 commits into from
Jun 30, 2021

Commits on Jun 15, 2021

  1. Opt test out of LogPropertiesAndItemsAfterEvaluation 

    OutOfProcNodeForwardCertainproperties is explicitly testing a feature where only some properties are forwarded from a different process on ProjectStartedEventArgs. When we move properties to ProjectEvaluationFinished the test loses meaning. So force it into the old behavior via an escape hatch.
    @KirillOsenkov
    KirillOsenkov committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    702dfb5 View commit details
    Browse the repository at this point in the history

  2. Skip NullMetadataOnLegacyOutputItems_InlineTask 

    The feature the test is testing is broken, but the test passes because it doesn't specify diag verbosity for its logger.

We will only log task outputs with diag verbosity.

Issue #6521 is tracking.
    @KirillOsenkov
    KirillOsenkov committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    55be3a5 View commit details
    Browse the repository at this point in the history

  3. Skip TestItemsWithUnexpandableMetadata 

    Issue #6518 is tracking.

More work is needed to understand the desired behavior of the system under test and then fix the test to test the desired behavior.
    @KirillOsenkov
    KirillOsenkov committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    264a797 View commit details
    Browse the repository at this point in the history

  4. Console logger support for IncludeEvaluationPropertiesAndItems 

    Call IEventSource4.IncludeEvaluationPropertiesAndItems()

OutputItems was pretty much duplicated in ParallelConsoleLogger. Unify with the base implementation and extract methods that need to be replaced by the derived type.

Support for reading project configuration description either from ProjectStartedEventArgs.Items or ProjectEvaluationFinishedEventArgs.Items.
    @KirillOsenkov
    KirillOsenkov committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    c813836 View commit details
    Browse the repository at this point in the history