Fix NativeMethods.IsSymLink #8282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Framework/NativeMethods.cs
Outdated
| static bool GetFileAttributeTagInfoByHandle(SafeFileHandle fileHandle, out FileAttributeTagInfo fileAttributeTagInfo) | ||
| { | ||
| int typeSize = Marshal.SizeOf(typeof(FileAttributeTagInfo)); | ||
| IntPtr ptr = Marshal.AllocHGlobal(typeSize); |
There was a problem hiding this comment.
Thanks for pointing - simplifying...
Forgind
approved these changes
Jan 9, 2023
|
Superseded by #8306 |
JaynieBai
pushed a commit
that referenced
this pull request
Jan 18, 2023
Fixes #6773 Context Supersedes #8213 and #8282 Symlinked files were not embedded into binlog - previous solution was too much focused on symlinks and hence requried nontrivial code to properly distinguish aymlinks with available contnet. Alternate approach - proceed with adding file as soon as it has available content Testing Preexisting unit test is excercising the scenario. Added a case for empty file - that still should not be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6773
Context
Original PR #8213 had imprecise implementation of
IsSymLink- fixing this.Details: #8213 (comment)
Special thanks to @KalleOlaviNiemitalo for pointing out the issue and proposing remedy options.
Changes Made
IsSymLinknow usesGetFileInformationByHandleExto obtain file attributes and detect symlink in case reparse point was detected.Testing
Cover by unit test added in original PR