Shouldly 4.2.1 #8717
Merged
Shouldly 4.2.1 #8717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all changes are fallout from https://docs.shouldly.org/documentation/3to4#func-less-than-string-greater-than-custommessage-removed. Fixes were: always materialize the string up front, and sometimes explicitly specify `customMessage:` to disambiguate methods.
|
Ugh. A change in Shouldly is making it do reference-equal equality for |
Works around shouldly/shouldly#825.
JanKrivanek
approved these changes
May 2, 2023
|
Looks good (as soon as quite a few missing method exceptions |
|
Let's time box it with 1 dev day. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hey, this is green now, thanks @GangWang01! Should we undraft and review it? |
|
I think it's ready for review. |
|
LGTM! |
maridematte
approved these changes
Oct 30, 2023
YuliiaKovalova
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all changes are fallout from https://docs.shouldly.org/documentation/3to4#func-less-than-string-greater-than-custommessage-removed.
Fixes were: always materialize the string up front, and sometimes
explicitly specify
customMessage:to disambiguate methods.