-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Copy task LogDiagnostics Warning so it is suppressible #9217
Change Copy task LogDiagnostics Warning so it is suppressible #9217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove/alter the existing comment (it's confusing now) - than I'm OK with change. As soon as the MessageImportance.High
was considered and there are reasons not to use it.
b320586
to
caf06d1
Compare
Not closed actually, but hard reset + force push have confused github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We just need to pick unique error codes
These strings were introduced in dotnet#9217 but caused loc breaks. Fixes dotnet#9283.
These strings were introduced in dotnet#9217 but caused loc breaks. Fixes dotnet#9283.
Fixes #9210
Context
Copy task implement
LogDiagnostics
as warnings. This is causing issues for/WarnAsError
use cases.Changes Made
Change Copy task
LogDiagnostics
from Warning to low importance Message.The reasoning for Warning level "so it's easily visible" is, IMO, not strong enough.
Testing
Unit tests.
Locally.
Notes
@rainersigwald Since we see increasing number of people reporting issues with Copy conflicts, I believe it is candidate for 17.8