Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed source file from CodeTaskFactory and RoslynCodeTaskFactory in binlog #9746

Merged
merged 71 commits into from
Mar 20, 2024
Merged

Embed source file from CodeTaskFactory and RoslynCodeTaskFactory in binlog #9746

merged 71 commits into from
Mar 20, 2024

Commits on Feb 15, 2024

  1. embed source file from CodeTaskFactory and RoslynCodeTaskFactory in b… 

    …inlog
    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    29f8489 View commit details
    Browse the repository at this point in the history

  2. remove Shouldly from CodeTaskFactoryTests

    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    da93ecd View commit details
    Browse the repository at this point in the history

  3. Revert "remove Shouldly from CodeTaskFactoryTests" 

    This reverts commit da93ecd.
    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5f08399 View commit details
    Browse the repository at this point in the history

  4. moved unit test for RoslynCodeTaskFactory

    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    693a612 View commit details
    Browse the repository at this point in the history

  5. small fix

    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    37a21d9 View commit details
    Browse the repository at this point in the history

  6. Update src/Tasks.UnitTests/RoslynCodeTaskFactory_Tests.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @surayya-MS @rainersigwald
    surayya-MS and rainersigwald authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    76f1a4b View commit details
    Browse the repository at this point in the history

  7. make SourceFilePath nullable

    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d96df3c View commit details
    Browse the repository at this point in the history

  8. log source file in case of compilation failure too

    @surayya-MS
    surayya-MS committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    488dd86 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. fix

    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    bfa5c54 View commit details
    Browse the repository at this point in the history

  2. add tests for case when source file fails to compile

    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    2a2eabc View commit details
    Browse the repository at this point in the history

  3. fix

    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    faafcc4 View commit details
    Browse the repository at this point in the history

  4. fix spaces

    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    448aba8 View commit details
    Browse the repository at this point in the history

  5. fix formatting

    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4e6191c View commit details
    Browse the repository at this point in the history

  6. remove RoslynCodeTaskFactory tests to see if Windows Core and Windows… 

    … Full fail or not
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    601d3d1 View commit details
    Browse the repository at this point in the history

  7. remove CodeTaskFactory tests to see if Windows Core and Windos Full f… 

    …ail or not
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    aea4ee7 View commit details
    Browse the repository at this point in the history

  8. Revert "remove CodeTaskFactory tests to see if Windows Core and Windo… 

    …s Full fail or not"

This reverts commit aea4ee7.
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8021d78 View commit details
    Browse the repository at this point in the history

  9. Revert "remove RoslynCodeTaskFactory tests to see if Windows Core and… 

    … Windows Full fail or not"

This reverts commit 601d3d1.
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    9ba7906 View commit details
    Browse the repository at this point in the history

  10. Reapply "remove CodeTaskFactory tests to see if Windows Core and Wind… 

    …os Full fail or not"

This reverts commit 8021d78.
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    9a55dd9 View commit details
    Browse the repository at this point in the history

  11. test if binary logger in ObjectModelHelpers is the problem

    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    cf859ea View commit details
    Browse the repository at this point in the history

  12. Revert "test if binary logger in ObjectModelHelpers is the problem" 

    This reverts commit cf859ea.
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    6477957 View commit details
    Browse the repository at this point in the history

  13. Revert "Reapply "remove CodeTaskFactory tests to see if Windows Core … 

    …and Windos Full fail or not""

This reverts commit 9a55dd9.
    @surayya-MS
    surayya-MS committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    1ca25d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. fix pipeline problem

    @surayya-MS
    surayya-MS committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    938a05f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/surayya-MS/msbuild

    @surayya-MS
    surayya-MS committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d121f3f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into embe-file-from-CodeTaskFactory

    @surayya-MS
    surayya-MS committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b6100f6 View commit details
    Browse the repository at this point in the history

  4. Convert to raw strings

    @rainersigwald
    rainersigwald committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a2d5f70 View commit details
    Browse the repository at this point in the history

  5. Use test environment

    @rainersigwald
    rainersigwald committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d66abaf View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. change CodeTaskFactoryTests to be similar to RoslynCodeTaskFactory tests

    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e43ec80 View commit details
    Browse the repository at this point in the history

  2. Update src/Tasks.UnitTests/RoslynCodeTaskFactory_Tests.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @surayya-MS @rainersigwald
    surayya-MS and rainersigwald authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f5b5be8 View commit details
    Browse the repository at this point in the history

  3. Update src/Tasks.UnitTests/RoslynCodeTaskFactory_Tests.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @surayya-MS @rainersigwald
    surayya-MS and rainersigwald authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a3e4643 View commit details
    Browse the repository at this point in the history

  4. Update src/Tasks.UnitTests/RoslynCodeTaskFactory_Tests.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @surayya-MS @rainersigwald
    surayya-MS and rainersigwald authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    198da60 View commit details
    Browse the repository at this point in the history

  5. Update src/Tasks.UnitTests/RoslynCodeTaskFactory_Tests.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @surayya-MS @rainersigwald
    surayya-MS and rainersigwald authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a5e8f15 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'embe-file-from-CodeTaskFactory' of https://github.com/s… 

    …urayya-MS/msbuild into embe-file-from-CodeTaskFactory
    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d2317eb View commit details
    Browse the repository at this point in the history

  7. make IHasSourceFilePath internal

    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    19d0f05 View commit details
    Browse the repository at this point in the history

  8. small fix

    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    66f1ad0 View commit details
    Browse the repository at this point in the history

  9. small fix

    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    68d4f77 View commit details
    Browse the repository at this point in the history

  10. rename file

    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3482412 View commit details
    Browse the repository at this point in the history

  11. remove unnecessary variable

    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b0dde8e View commit details
    Browse the repository at this point in the history

  12. embed generated files from CodeTaskFactory and RoslynCodeTaskFactory … 

    …in binlog
    @surayya-MS
    surayya-MS committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3576fb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' of https://github.com/surayya-MS/msbuild

    @surayya-MS
    surayya-MS committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    977fe93 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into embe-file-from-CodeTaskFactory

    @surayya-MS
    surayya-MS committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e76dfd9 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. log file from memory in binlog

    @surayya-MS
    surayya-MS committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    24ad7ef View commit details
    Browse the repository at this point in the history

  2. add summary for LogIncludeGeneratedFile

    @surayya-MS
    surayya-MS committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    218ff2a View commit details
    Browse the repository at this point in the history

  3. small fix

    @surayya-MS
    surayya-MS committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    42ed5ea View commit details
    Browse the repository at this point in the history

  4. rename variable and add summary

    @surayya-MS
    surayya-MS committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9f200a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. move using static to the end

    @surayya-MS
    surayya-MS committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    219ba79 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. small fix

    @surayya-MS
    surayya-MS committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    23a4dbc View commit details
    Browse the repository at this point in the history

  2. use ExtendedBuildMessageEventArgs instead of a custom created event

    @surayya-MS
    surayya-MS committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    907a293 View commit details
    Browse the repository at this point in the history

  3. set message importance

    @surayya-MS
    surayya-MS committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d1b9cbd View commit details
    Browse the repository at this point in the history

  4. use different constructor ExtendedBuildMessageEventArgs

    @surayya-MS
    surayya-MS committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cbd7e0b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. fix linux and macos tests

    @surayya-MS
    surayya-MS committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4f358f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. use new custom event ResponseGeneratedFileEventArgs

    @surayya-MS
    surayya-MS committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2618a02 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. 1. embed the compilation file as {projectDirectory}/{guid}-{taskName}… 

    …-compilation-file.tmp

2. use helper for tests to reduce code repetition
    @surayya-MS
    surayya-MS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    503894a View commit details
    Browse the repository at this point in the history

  2. remove unnessesary usings from tests

    @surayya-MS
    surayya-MS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1f5d3cc View commit details
    Browse the repository at this point in the history

  3. add summary for projectDirectory

    @surayya-MS
    surayya-MS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a803d68 View commit details
    Browse the repository at this point in the history

  4. fix test

    @surayya-MS
    surayya-MS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1809224 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. rename new event to GeneratedFileUsedEventArgs; 

    update version in BinaryLogger;
    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f71f22d View commit details
    Browse the repository at this point in the history

  2. remove IHasProjectFullPath and instead get the project directory from… 

    … relative file path inside BinaryLogger
    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7f56f40 View commit details
    Browse the repository at this point in the history

  3. rename GeneratedFileUsedEventArgs properties

    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    06e4f59 View commit details
    Browse the repository at this point in the history

  4. rename variables

    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d1d1f9b View commit details
    Browse the repository at this point in the history

  5. rename property

    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    22d8da2 View commit details
    Browse the repository at this point in the history

  6. Add summaries for GeneratedFileUsedEventArgs properties

    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    dd444c6 View commit details
    Browse the repository at this point in the history

  7. fix typo in variable name

    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c9b98f1 View commit details
    Browse the repository at this point in the history

  8. fix

    @surayya-MS
    surayya-MS committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7a27083 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. remove Serializable attribute from GeneratedFileUsedEventArgs

    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    fb7031f View commit details
    Browse the repository at this point in the history

  2. Revert "remove Serializable attribute from GeneratedFileUsedEventArgs" 

    This reverts commit fb7031f.
    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0f612d5 View commit details
    Browse the repository at this point in the history

  3. move serialization logic to WriteToStream/CreateFromStream in Generat… 

    …edFileUsedEventArgs;

add node packets test cases for new event args
    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2133ebc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/surayya-MS/msbuild

    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9d80c28 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into embe-file-from-CodeTaskFactory

    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a1f9cef View commit details
    Browse the repository at this point in the history

  6. add serialazible back

    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    95b1d5b View commit details
    Browse the repository at this point in the history

  7. add serialization/desirialization test for GeneratedFileUsedEventArgs

    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    17a0b09 View commit details
    Browse the repository at this point in the history

  8. remove serializable attribute from GeneratedFileUsedEventArgs; 

    skip GeneratedFileUsedEventArgs in TaskFactoryLoggingHost.IsEventSerializable
    @surayya-MS
    surayya-MS committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ac256be View commit details
    Browse the repository at this point in the history