-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0.1xx] Bump System.Security.Cryptography.Xml to 6.0.1 and System.Security.Cryptography.Pkcs to 6.0.4 #9867
Conversation
Hi @premun, Could you help us with that? We need a build with the dependency bump . |
Sorry, I don't follow. Help with what exactly? |
@premun , I apologize for confusion. |
Sorry, I am not the best person for SB problems. @dotnet/source-build-internal Yulia has some issues with restoring |
The error seems completely unrelated to the changes. Are you sure this branch is building without these changes? Do you have the latest 6.0 Arcade in this branch? /cc @mmitche |
@GangWang01 please look at the tests failures. update: it's related to vs-image update. Hopefully, @rainersigwald will resolve it. |
This reverts commit 2eff919.
This was breaking builds but 17.0 really did build on and ship from VS2019, so we should keep doing so for servicing.
It looks like the test failures were resolved by Rainer. Thanks Rainer! |
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
…https://github.com/YuliiaKovalova/msbuild into dev/ykovalova/bump_System.Security.Cryptography_17.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose changes in eng.. were automatic via the arcade update - correct? Or is there any specific manual changes that should be reviewed with care?
Nope, these changes were added by running |
@YuliiaKovalova will you be merging this anytime soon. I'm hoping for F# to use the nuget packages from it. |
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
Summary
This is a security fix after the recent scanner results for sdk repo.
Customer Impact
No impact is expected.
Regression?
No
Testing
N/A
Risk
Minimal - no risks, it's just package version update + data from arcade .Net 6 Eng channel