Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to tag a public version based on calculated nbgv version #21

Closed
japj opened this issue May 1, 2020 · 3 comments
Closed

Add option to tag a public version based on calculated nbgv version #21

japj opened this issue May 1, 2020 · 3 comments

Comments

@japj
Copy link

japj commented May 1, 2020

e.g. to ensure a published package has a corresponding git tag

(although you could also use the nbgv tool to match a version to a commit ofcourse)

@AArnott
Copy link
Collaborator

AArnott commented May 10, 2020

Are you wanting nbgv to create a git tag and push it to your repo?
Under what conditions would it do that? Or do you want every "public release" commit that is ever built to have a tag pushed for it?

@japj
Copy link
Author

japj commented May 10, 2020

Sorry, I am not entirely sure anymore ;(

I was/am working on a native nodejs library with github actions workflow for prebuilding binaries.
And prebuild can create a github release in case it’s not there yet, but I believe that is based on the tag.
I think this might a think over again on how my complete (publishing) workflow should be in the end.

Should have put more background info in here for myself to correctly remember

@AArnott
Copy link
Collaborator

AArnott commented May 10, 2020

If your workflow creates a github release, that can identify the commit in the release itself. Then, if you ever publish that release, github automatically pushes a tag to your repo based on that commit and the name of the release.
This is actually how I release all my software. I create the github release from an Azure Pipeline as a 'draft' release, and I publish manually after I review the release notes.

@AArnott AArnott closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants