GSI protocol for multi-clusters #1800

sebastianburckhardt · 2016-05-31T22:41:11Z

Implements Global-single-instance registration strategy. This is the next installment of the Geo-Distribution Project #948.

galvesribeiro · 2016-05-31T23:28:20Z

@sebastianburckhardt great work!

Question... Since every silo has a LocalGrainDirectory and I you added a RemClusterGrainDirectory to it so, does that means that each silo will keep a copy of the whole cluster directory? Would not be better if we have global grains registered as grains inside the local directory and somehow have it marked as a global grain? Just for simplicity... I didn't understood the rationale behind the decision to keep a diff directory that will be hold by all the clusters.

Besides that question, greet work. LGTM.

Thanks! #Closed

sebastianburckhardt · 2016-06-01T14:39:30Z

I know it does not look that way, but there is actually only one grain directory. I agree that it is definitely cleaner that way (consider handoff etc.). RemClusterGrainDirectory is a wrapper around the LocalGrainDirectory that implements the IClusterGrainDirectory functions, which are called from remote clusters. This is the same pattern that already existed for RemGrainDirectory, which is a wrapper around LocalGrainDirectory as well, and implements the IRemoteGrainDirectory functionality. #Closed

galvesribeiro · 2016-06-01T14:59:47Z

Ok got it. Thanks! Great work, LGTM #Closed

Optimized multiple Linq Count calls with Aggregate

…nRequestBatch

jdom · 2016-06-11T00:39:02Z

src/OrleansRuntime/GrainDirectory/MultiClusterRegistration/MultiClusterUtils.cs

+            }
+
+            var precLeft = grain.GetUniformHashCode() ^ clusterLeft.GetHashCode();
+            var precRight = grain.GetUniformHashCode() ^ clusterRight.GetHashCode();


should not use String.GetHashCode(). Create and use a uniform hashcode instead, as the value of GetHashCode might be different depending on where it is ran. #Closed

ok. #Closed

sebastianburckhardt · 2016-06-22T17:36:20Z

Unregistration of global-single-instance grains seems to not have not been thought through completely. Need to fix this. I think we can do the equivalent of what is done within a cluster (send unregistration messages, and if those should get lost for any reason, fall back on removing stale directory entries when detecting NonExistentActivation exceptions). #Closed

sergeybykov · 2016-06-23T06:03:36Z

@sebastianburckhardt

I think we can do the equivalent of what is done within a cluster (send unregistration messages, and if those should get lost for any reason, fall back on removing stale directory entries when detecting NonExistentActivation exceptions).

I think that's alright. I can't think of a simple better solution. Let's see how it works, iterate if necessary. #Closed

jdom · 2016-07-13T22:47:32Z

src/OrleansRuntime/GrainDirectory/GrainDirectoryPartition.cs

@@ -124,6 +126,22 @@ public bool RemoveActivation(ActivationId act, bool force)
            return Instances.Count == 0;
        }

+        public IActivationInfo LookupAndRemoveActivation(ActivationAddress address, bool force)


this method shares some (non-trivial) logic duplication with the method above (RemoveActivation) although they differ slightly in the case of force==true. Is this by design or should they be doing the same and avoiding duplication instead? #Closed

For the case I implemented, I need to know if an activation was removed, and if so, what was its content.
I could not see how to do that without adding a new LookupAndRemove function on the directory.

The existing RemoveActivation does not always do a lookup, and does not return an activation. Instead, it returns a boolean indicating whether there are any activations left after the remove.

#Closed

Refactor GSI response tracker

…alsingleinstance

sergeybykov · 2016-09-07T22:52:27Z

Looks like we are down to a single remaining design issue - with Cluster ID on the client. I'll try to look if there's a reasonable way to avoid passing it through client config. #Closed

sergeybykov · 2016-09-08T04:58:28Z

I submitted a PR - sebastianburckhardt#6 against @sebastianburckhardt's branch to eliminate the need to configure cluster ID on the client side.

Change initialization of OutsideRuntimeClient to start with a handshake client ID, and update it with cluster ID received from gateway.

…kCycle field can cause NullPointerException).

sergeybykov · 2016-09-09T20:27:07Z

Shouldn't 84ee457 go as a separate PR, if it fixes a general bug?

sebastianburckhardt · 2016-09-09T20:29:39Z

If you prefer. It's your call. (It's a very small change).

sergeybykov · 2016-09-09T20:32:59Z

I think it is better to review (and merge if everything is fine) separately. You can leave it in this branch for now for testing. When you finally rebase/squash, it will disappear if it's already merge to master by then.

…onflicts in src/Orleans/Messaging/Message.cs caused by dotnet#2124

…BatchWorker.cs due to dotnet#2133

sergeybykov · 2016-09-09T23:31:26Z

I got a dozen functional test failures. Need to investigate what's going on there.

jdom · 2016-09-16T23:20:16Z

Thanks a lot @sebastianburckhardt and everyone involved in this effort. It took 3 months, but this is IN!

sergeybykov · 2016-09-17T00:02:09Z

It was an epic effort. Thank you all!

Implement Global-single-instance registration strategy

500fb74

dnfclas added the cla-already-signed label May 31, 2016

sebastianburckhardt added this to the Multi-Cluster milestone May 31, 2016

jdom mentioned this pull request Jun 10, 2016

Explain "Orleans deployments are currently limited to a single data center per deployment" #1831

Closed

jdom added 3 commits June 10, 2016 17:29

Code style cleanup

6e80ddc

Optimized multiple Linq Count calls with Aggregate

ClusterGrainDirectory optimizations

a0faeca

Returning ResponseException in ClusterGrainDirectory.ProcessActivatio…

a383fbd

…nRequestBatch

jdom reviewed Jun 11, 2016
View reviewed changes

sebastianburckhardt added 4 commits June 13, 2016 14:16

fix cluster precedence function, not to use string.GetHashCode()

50e7c09

remove unnecessary "virtual" declarations.

de99b20

delete commented-out code.

78ea957

rename Notify() to CheckIfDone()

ac093db

sebastianburckhardt mentioned this pull request Jun 28, 2016

Geo-Distribution Project #948

Closed

Add support for deregistration and deletion. Add more tests.

6c2e0de

sergeybykov modified the milestones: 1.3.0, Multi-Cluster Jul 6, 2016

sergeybykov assigned jdom Jul 11, 2016

jdom reviewed Jul 13, 2016
View reviewed changes

sebastianburckhardt and others added 3 commits September 6, 2016 11:37

make number of GSI retries configurable.

673ce44

Compose TCS instead of inheriting

dd30bb7

Refactor to use promises

72207b8

jdom mentioned this pull request Sep 6, 2016

Refactor GSI response tracker sebastianburckhardt/orleans#5

Merged

jdom and others added 6 commits September 6, 2016 15:58

Refactor GSI response tracker

aa96508

Trace extended information about GSI owner response

ea1b397

Merge pull request #5 from jdom/geo-globalsingleinstance-responsetracker

b7fd5fe

Refactor GSI response tracker

Add code comments

254014b

Merge branch 'geo-globalsingleinstance-responsetracker' into geo-glob…

6d051a7

…alsingleinstance

Merge branch 'orleans-master' into geo-globalsingleinstance

bc20980

sergeybykov and others added 2 commits September 9, 2016 10:17

Remove cluster ID from client config (#6)

e800f6c

Change initialization of OutsideRuntimeClient to start with a handshake client ID, and update it with cluster ID received from gateway.

fix a synchronization bug in BatchWorker (rare race on the currentWor…

84ee457

…kCycle field can cause NullPointerException).

sebastianburckhardt added 2 commits September 9, 2016 15:32

Merge branch 'orleans-master' into geo-globalsingleinstance and fix c…

13bbf8e

…onflicts in src/Orleans/Messaging/Message.cs caused by dotnet#2124

Merge branch 'orleans-master' and fix conflicts in src/Orleans/Async/…

56e3061

…BatchWorker.cs due to dotnet#2133

sergeybykov added the testing label Sep 10, 2016

jdom and others added 2 commits September 15, 2016 11:41

Start ClientStatisticsManager after clientID is assigned (#7)

a3965ba

Merge branch 'orleans-master' into geo-globalsingleinstance

7637b8b

jdom merged commit ed1b4ef into dotnet:master Sep 16, 2016

veikkoeeva mentioned this pull request Sep 22, 2016

Geo-distributed gossip channel implementation for current membership back-ends #2207

Closed

sebastianburckhardt deleted the geo-globalsingleinstance branch September 22, 2016 22:58

github-actions bot locked and limited conversation to collaborators Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GSI protocol for multi-clusters #1800

GSI protocol for multi-clusters #1800

sebastianburckhardt commented May 31, 2016

galvesribeiro commented May 31, 2016 •

edited by sergeybykov

Loading

sebastianburckhardt commented Jun 1, 2016 •

edited by sergeybykov

Loading

galvesribeiro commented Jun 1, 2016 •

edited by sergeybykov

Loading

jdom Jun 11, 2016 •

edited

Loading

sebastianburckhardt Jun 13, 2016 •

edited by sergeybykov

Loading

sebastianburckhardt commented Jun 22, 2016 •

edited by sergeybykov

Loading

sergeybykov commented Jun 23, 2016 •

edited

Loading

jdom Jul 13, 2016 •

edited by sergeybykov

Loading

sebastianburckhardt Jul 14, 2016 •

edited by sergeybykov

Loading

sergeybykov commented Sep 7, 2016 •

edited

Loading

sergeybykov commented Sep 8, 2016

sergeybykov commented Sep 9, 2016

sebastianburckhardt commented Sep 9, 2016

sergeybykov commented Sep 9, 2016

sergeybykov commented Sep 9, 2016

jdom commented Sep 16, 2016

sergeybykov commented Sep 17, 2016

GSI protocol for multi-clusters #1800

GSI protocol for multi-clusters #1800

Conversation

sebastianburckhardt commented May 31, 2016

galvesribeiro commented May 31, 2016 • edited by sergeybykov Loading

sebastianburckhardt commented Jun 1, 2016 • edited by sergeybykov Loading

galvesribeiro commented Jun 1, 2016 • edited by sergeybykov Loading

jdom Jun 11, 2016 • edited Loading

Choose a reason for hiding this comment

sebastianburckhardt Jun 13, 2016 • edited by sergeybykov Loading

Choose a reason for hiding this comment

sebastianburckhardt commented Jun 22, 2016 • edited by sergeybykov Loading

sergeybykov commented Jun 23, 2016 • edited Loading

jdom Jul 13, 2016 • edited by sergeybykov Loading

Choose a reason for hiding this comment

sebastianburckhardt Jul 14, 2016 • edited by sergeybykov Loading

Choose a reason for hiding this comment

sergeybykov commented Sep 7, 2016 • edited Loading

sergeybykov commented Sep 8, 2016

sergeybykov commented Sep 9, 2016

sebastianburckhardt commented Sep 9, 2016

sergeybykov commented Sep 9, 2016

sergeybykov commented Sep 9, 2016

jdom commented Sep 16, 2016

sergeybykov commented Sep 17, 2016

galvesribeiro commented May 31, 2016 •

edited by sergeybykov

Loading

sebastianburckhardt commented Jun 1, 2016 •

edited by sergeybykov

Loading

galvesribeiro commented Jun 1, 2016 •

edited by sergeybykov

Loading

jdom Jun 11, 2016 •

edited

Loading

sebastianburckhardt Jun 13, 2016 •

edited by sergeybykov

Loading

sebastianburckhardt commented Jun 22, 2016 •

edited by sergeybykov

Loading

sergeybykov commented Jun 23, 2016 •

edited

Loading

jdom Jul 13, 2016 •

edited by sergeybykov

Loading

sebastianburckhardt Jul 14, 2016 •

edited by sergeybykov

Loading

sergeybykov commented Sep 7, 2016 •

edited

Loading