ClientGenerator packs OrleansCodeGenerator.Build package #2990
Conversation
jdom
commented
May 2, 2017
jdom
commented
- ClientGenerator.csproj generates the nuget package directly
- Remove meta package and scripts that build the built-time codegen package separately
- Allow setting nuget version from msbuild arguments
- ClientGenerator.csproj generates the nuget package directly - Remove meta package and scripts that build the built-time codegen package separately - Allow setting nuget version from msbuild arguments
| <PackagePath>build\$(PackageId).targets</PackagePath> | ||
| <Visible>false</Visible> | ||
| </None> | ||
| <None Include="$(OutDir)/ClientGenerator.exe.config"> |
There was a problem hiding this comment.
It's a little unfortunate that these need to be included manually instead of the references being automatically included in the package, but so be it, I suppose.
There was a problem hiding this comment.
yes, I think there is room for improvement... Ideally we can use a build property that already has all the files that end up in the output folder. I couldn't find it, but at least I preserved the old behavior (plus including PlatformServices, which for some reason wasn't being included before, not sure how it was working)
- Update HelloWorld.NetCore sample to download packages from MyGet feed
|
Seems that this is an issue for others too: NuGet/Home#4360 Once we start multi-targeting ClientGenerator, we should probably drop IsTool, and instead use the approach suggested by @AArnott in that thread |
