Implement ISerializable fallback serializer #6917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
feature/exception-serializer
branch
from
e2aa513
to
751cdae
Compare
ReubenBond
force-pushed
the
feature/exception-serializer
branch
from
751cdae
to
4f1be6c
Compare
ReubenBond
force-pushed
the
feature/exception-serializer
branch
from
3ac3ac9
to
cbceecf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new serializer specifically for conforming
ISerializableimplementations. This is intended to replace most of the use case that we currently have forBinaryFormatter, which is blocked in .NET 5This also adds fallback exception serialization so that exception types which are unknown by the deserializing party (eg, the caller of a method which throws) can be deserialized into a special type, maintaining the stack.
Additionally, this supports deserializing exception types which do not expose a protected deserialization constructor (because they did not correctly implement the
ISerializablepattern)