Support ILBasedSerializer as a fallback only after trying the configured fallback #7357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs some changes. I'll push an update tomorrow |
ReubenBond
force-pushed
the
v3/fix-ilbased-fallback
branch
from
be61a27
to
79b3c7a
Compare
|
Another commit on the pile: BinaryFormatter (which is enabled in more situations with this PR) dropped support for serializing RuntimeType in .NET Core 2.0: dotnet/runtime#23169 (comment) |
ReubenBond
commented
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7328
We should not use ILBasedSerializer preferentially to the configured fallback serializer. This PR deprioritizes it.
Microsoft Reviewers: Open in CodeFlow