Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObserverManager: fix Collection was modified #8707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Orleans.Core/Utils/ObserverManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public async Task Notify(Func<TObserver, Task> notification, Func<TObserver, boo
{
var now = GetDateTime();
var defunct = default(List<TIdentity>);
foreach (var observer in _observers)
foreach (var observer in _observers.ToList())
{
if (observer.Value.LastSeen + ExpirationDuration < now)
{
Expand Down Expand Up @@ -208,7 +208,7 @@ public void Notify(Action<TObserver> notification, Func<TObserver, bool> predica
{
var now = GetDateTime();
var defunct = default(List<TIdentity>);
foreach (var observer in _observers)
foreach (var observer in _observers.ToList())
{
if (observer.Value.LastSeen + ExpirationDuration < now)
{
Expand Down Expand Up @@ -257,7 +257,7 @@ public void ClearExpired()
{
var now = GetDateTime();
var defunct = default(List<TIdentity>);
foreach (var observer in _observers)
foreach (var observer in _observers.ToList())
{
if (observer.Value.LastSeen + ExpirationDuration < now)
{
Expand Down
Loading