Consider interface method accessibility when generating the invoker #9019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrz
commented
May 22, 2024
Comment on lines
+41
to
+42
| //protected class P2; | ||
| //protected Task M2(P2 arg); |
There was a problem hiding this comment.
This PR does not fix codegen for protected members.
For those I think we should change the body to "throw unreachable" and skip the invoker completely..
ReubenBond
reviewed
May 22, 2024
| @@ -92,8 +92,8 @@ public GeneratedInvokableDescription Generate(InvokableMethodDescription invokab | |||
|
|
|||
| static Accessibility GetAccessibility(IMethodSymbol methodSymbol) | |||
| { | |||
| Accessibility accessibility = methodSymbol.DeclaredAccessibility; | |||
There was a problem hiding this comment.
If the type is internal and the method is public, what will the value of DeclaredAccessibilty be?
There was a problem hiding this comment.
That's gonna be public, which will be downgraded to internal after the loop below.
ReubenBond
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8973 (partially)
Microsoft Reviewers: Open in CodeFlow