Add Workflow definition build rule (XamlAppDef) #3810
Conversation
Did you try setting the |
| @@ -171,6 +171,10 @@ | |||
| <Context>File</Context> | |||
| </PropertyPageSchema> | |||
|
|
|||
| <PropertyPageSchema Include="$(ManagedXamlResourceDirectory)XamlAppDef.xaml"> | |||
| <Context>File</Context> | |||
There was a problem hiding this comment.
This needs to be 'File;BrowseObject'.
|
F5 will correctly setup the environment to pick up new rules + targets, so if Experimental instance isn't working, then the bug hasn't been fixed. Also you need to modify setup\Microsoft.VisualStudio.ProjectSystem.Managed.CommonFiles\CommonFiles.swr to make sure the new rule gets installed. |
davkean
added
the
Community
Codecov Report
@@ Coverage Diff @@
## master #3810 +/- ##
=======================================
Coverage 68.36% 68.36%
=======================================
Files 595 595
Lines 34248 34248
Branches 1935 1935
=======================================
Hits 23414 23414
Misses 10484 10484
Partials 350 350
Continue to review full report at Codecov.
|
|
Now this is really weird... I added |
|
This should cause us to pick it up from the recently build artifacts folder. Look in the Output window of the debugger for CPS tracing that might indicate what's going on. I can look latter to see what's going on. |
|
I'll do so tomorrow, after I get off work. Thanks! |
|
@davkean I've looked at the Output window, and see nothing that looks like CPS tracing. All I see are a lot of rote assembly load/unload log statements. Here's the full log. |
| Name="XamlAppDef" | ||
| DisplayName="General" | ||
| PageTemplate="generic" | ||
| Description="File Properties" |
There was a problem hiding this comment.
This is missing PropertyPagesHidden="true"
|
As a side note, I'd like this contribution to be squashed - feel free to do it, or I'll do when I merge this in. I'm going to use it as an example for adding a new item type. |
| @@ -171,6 +171,10 @@ | |||
| <Context>File</Context> | |||
| </PropertyPageSchema> | |||
|
|
|||
| <PropertyPageSchema Include="$(ManagedXamlResourceDirectory)XamlAppDef.xaml"> | |||
There was a problem hiding this comment.
This property is missing an "s"; should be $(ManagedXamlResourcesDirectory).
There was a problem hiding this comment.
Fixed, but it still doesn't seem to work. Please keep looking. Thanks!
| Category="Misc" | ||
| Description="The item specified in the Include attribute."> | ||
| <StringProperty.DataSource> | ||
| <DataSource Persistence="Intrinsic" ItemType="None" PersistedName="Identity" SourceOfDefaultValue="AfterContext" /> |
There was a problem hiding this comment.
Replace every usage of ItemType="None" with ItemType="XamlAppDef".
There was a problem hiding this comment.
Even better, delete the ItemType from all properties. This is automatically pulled from the DataSource on the rule itself.
There was a problem hiding this comment.
Filed to #3815 to basically do this across all the rules so we never run into this again.
There was a problem hiding this comment.
Also filed #3816. We have tracing for a bunch of this, but we hook up too late for it to be output into the Output window.
There was a problem hiding this comment.
Strike removing the ItemType, I'm replacing it with XamlAppDef. It's required for the BrowseObject but not for the File context.
|
With the latest changes I've just pushed, this works. I'll merge it in when we are green. |
Does mostly what the title says. Some notes:
XamlAppDef.xamlfile fromNone.xaml, because I didn't think that any extra properties would be required. If additional properties needs to be placed in this file, please let me know.Thanks!