-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to 1ES template migration for official builds and mark others accordingly #7253
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
========================================
Coverage 96.48% 96.48%
========================================
Files 1439 1442 +3
Lines 344369 345212 +843
Branches 11324 11345 +21
========================================
+ Hits 332259 333082 +823
- Misses 9244 9256 +12
- Partials 2866 2874 +8 |
491fef2
to
1314115
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor question about the parameter. Other looks good
1314115
to
e2b75a2
Compare
e2b75a2
to
b5e7416
Compare
azure-pipelines-microbuild.yml
Outdated
outputs: | ||
# Archive NuGet packages to DevOps. | ||
- output: pipelineArtifact | ||
path: $(Build.ArtifactStagingDirectory)/packages/$(BuildConfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously the path was 'artifacts\packages\$(_BuildConfig)'
now it's $(Build.ArtifactStagingDirectory)/packages/$(BuildConfig)
which seems to resolve to D:\a\_work\1\a\packages\Release
which looks different and probably is the reason why you're getting failures in the CI run ##[error]Path does not exist: D:\a\_work\1\a\packages\Release
Applies to the output below as well.
Validation build is at https://dev.azure.com/dnceng/internal/_build/results?buildId=2410326&view=results. (SBOM publishing failure warning pending. Should not be a blocker though.)