Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CodeQL tasks duplicating injected ones #7267

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Mar 26, 2024

Follow up on #7253.

Currently official builds are getting stuck on CodeQL step: https://dnceng.visualstudio.com/internal/_build/results?buildId=2414766&view=results (interestingly, test run of #7253 didn't get stuck, not sure why)
Test run of an official build of this PR: https://dnceng.visualstudio.com/internal/_build/results?buildId=2414884&view=results
This is like a change done in roslyn-sdk to resolve the same problem: dotnet/roslyn-sdk@816cd02

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (00071ec) to head (2522861).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7267      +/-   ##
==========================================
- Coverage   96.48%   96.48%   -0.01%     
==========================================
  Files        1442     1442              
  Lines      345212   345212              
  Branches    11345    11345              
==========================================
- Hits       333086   333073      -13     
- Misses       9252     9263      +11     
- Partials     2874     2876       +2     

@jjonescz jjonescz marked this pull request as ready for review March 26, 2024 15:23
@jjonescz jjonescz requested a review from a team as a code owner March 26, 2024 15:23
@jjonescz jjonescz merged commit 0868ca2 into dotnet:main Mar 26, 2024
16 checks passed
@jjonescz jjonescz deleted the 1es-pt-codeql branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants