Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add projects for supporting source generator testing #694

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Add projects for supporting source generator testing #694

merged 3 commits into from
Jan 26, 2021

Conversation

sharwell
Copy link
Member

No description provided.

@sharwell sharwell marked this pull request as ready for review January 13, 2021 03:00
@sharwell sharwell requested a review from a team as a code owner January 13, 2021 03:00
@sharwell
Copy link
Member Author

@chsienki @jmarolf for reviews

@jmarolf
Copy link
Contributor

jmarolf commented Jan 25, 2021 

public sealed class EvaluatedProjectState

Curious if this could be a record

Refers to: src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/Model/EvaluatedProjectState.cs:13 in 90c7987. [](commit_id = 90c7987, deletion_comment = False)

jmarolf
jmarolf approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit 1b1b5ee into dotnet:master Jan 26, 2021
@sharwell sharwell deleted the test-generators branch January 26, 2021 01:15
@Youssef1313 Youssef1313 mentioned this pull request Feb 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @jmarolf