CSharpFixAllOccurrences.FixAllOccurrences fails intermittently

[tmat]

http://dotnet-ci.cloudapp.net/job/dotnet_roslyn_prtest_win_vsi_p2/680/

[Pilchie]

Looks like the error is finding failures to fix. @mavasani related to the FSD fix?

21:00:43 --------------------------------
21:00:43 System.Exception: Wrong number of errors in error list. Expected '9794', found '58'.
21:00:43 
21:00:43 Actual errors:
21:00:43 Do not use regions
21:00:43 The file header is missing or not located at the top of the file.
21:00:43 Using directive must appear within a namespace declaration
21:00:43 Elements must be documented
21:00:43 Enumeration items must be documented
21:00:43 Enumeration items must be documented
21:00:43 Enumeration items must be documented
21:00:43 Enumeration items must be documented
21:00:43 Enumeration items must be documented
21:00:43 Enumeration items must be documented
21:00:43 Enumeration items must be documented
21:00:43 Disposable fields should be disposed
21:00:43 The file header is missing or not located at the top of the file.
21:00:43 Using directive must appear within a namespace declaration
21:00:43 Field '_commentHandling' must not begin with an underscore
21:00:43 Field '_lineInfoHandling' must not begin with an underscore
21:00:43 All accessors must be single-line or multi-line
21:00:43 Prefix local calls with this
21:00:43 Elements must be separated by blank line
21:00:43 Prefix local calls with this
21:00:43 All accessors must be single-line or multi-line
21:00:43 Prefix local calls with this
21:00:43 Elements must be separated by blank line
21:00:43 Prefix local calls with this
21:00:43 The file header is missing or not located at the top of the file.
21:00:43 Using directive must appear within a namespace declaration
21:00:43 Using directive must appear within a namespace declaration
21:00:43 Using directive must appear within a namespace declaration
21:00:43 Elements must be documented
21:00:43 Elements must be documented
21:00:43 Elements must be documented
21:00:43 Prefix local calls with this
21:00:43 Prefix local calls with this
21:00:43 Prefix local calls with this
21:00:43 Prefix local calls with this
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Disposable fields should be disposed
21:00:43 Do not use regions
21:00:43 The file header is missing or not located at the top of the file.
21:00:43 Elements must be documented
21:00:43 Generic type constraints must be on their own line
21:00:43 Field '_name' must not begin with an underscore
21:00:43 Field '_value' must not begin with an underscore
21:00:43 Elements must be documented
21:00:43 Prefix local calls with this
21:00:43 Elements must be documented
21:00:43 Prefix local calls with this
21:00:43 Elements must be documented
21:00:43 A constructor should not follow a property
21:00:43 Prefix local calls with this
21:00:43 Prefix local calls with this
21:00:43 
21:00:43    at Roslyn.VSHosting.Test.VerifyErrorListAction.Execute(TaoEngine engine) in d:\j\workspace\dotnet_roslyn---b84db72c\Closed\Hosting\RoslynTaoActions\Actions\VisualStudio\VerifyErrorListAction.cs:line 66
21:00:43    at Tao.Engine.DebuggableActionExecutor.Execute() in f:\dd\src\Omni\Tao\Tao.Engine\ActionExecutor.cs:line 139
21:00:43    at Tao.Engine.DefaultActionExecutor.Execute() in f:\dd\src\Omni\Tao\Tao.Engine\ActionExecutor.cs:line 36
21:00:43 ================================
21:00:43 
21:00:43 
21:00:43 Saved screenshot: d:\j\workspace\dotnet_roslyn---b84db72c\Open\Binaries\Release\Screenshots\2016-04-26_03-51-44_67 - Exception System.Exception.png

[mavasani]

FSD wasn't checked into master till today morning - this seems unrelated. I am working on enhancing the logging for this test to give out better output when there is a count mismatch.

[mavasani]

Wow, so the screenshot shows Low Memory Detected - Full solution analysis turned off warning. Given that this is just a small Newtonsoft.json project with few thousand lines, this seems very surprising indeed.
@lgolding Should we modify the process watchdog to listen to low VM notifications and generate a dump (and possibly fail the test) when it happens?

[mavasani]

[mavasani]

We have replaced the IDE diagnostic engine and also improved the logging for the test. Please re-activate and assign to me if we see this test fail again.

[jasonmalinowski]

This is still failing regularly: http://dotnet-ci.cloudapp.net/job/roslyn-internal_prtest_win_vsi_p2/568/

[mavasani]

Screenshot shows we didn't get the diagnostic and/or code fix when light bulb was invoked. HeeJae, can you take a look?

[heejaechang]

@mavasani is this compilation end analyzer? or other kind of analyzer?

[mavasani]

This is stylecop analyzer SA1101. It's implementation is here - its a regular syntax node analyzer.