Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create active file analyzers non-lazily. #11221

Merged
merged 1 commit into from
May 10, 2016

Conversation

heejaechang
Copy link
Contributor

we used to create all solution crawler analyzers lazily. which means all analyzers only register themselves once the very first solution crawler pass has run.

this caused ctrl+. for LB right after solution open sometimes not work since solution crawler didn't run its first pass yet so there is no analyzers registered to system.

now, we create solution crawler analyzers for active files non-lazily. those analyzers should be ready right away once solution is up.

fix #10877

we used to create all solution crawler analyzers lazily. which means all analyzers only register themselves once the very first solution crawler pass has run.

this caused ctrl+. for LB right after solution open sometimes not work since solution crawler didn't run its first pass yet so there is no analyzers registered to system.

now, we create solution crawler analyzers for active files non-lazily. those analyzers should be ready right away once solution is up.
@heejaechang
Copy link
Contributor Author

test vsi please

@heejaechang
Copy link
Contributor Author

@dotnet/roslyn-analysis @mavasani @srivatsn can you take a look?

@mavasani
Copy link
Contributor

👍

@heejaechang heejaechang merged commit 39840b4 into dotnet:master May 10, 2016
@srivatsn
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSharpFixAllOccurrences.FixAllOccurrences fails intermittently
4 participants