Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Generators: IDE keyword recommender should know about "replace" #11191

Closed
VSadov opened this issue May 9, 2016 · 2 comments
Closed

Source Generators: IDE keyword recommender should know about "replace" #11191

VSadov opened this issue May 9, 2016 · 2 comments
Assignees
@VSadov
Labels
Area-Compilers Bug Language-C# New Language Feature - Replace/Original Replace/Original
Milestone
Language Feature ...

Comments

@VSadov
Copy link
Member

VSadov commented May 9, 2016

member declarations now can start with "replace".
Keyword recommender should not force that into things like "DecoderReplacementFallback"
@DustinCampbell
Copy link
Member

Moving language feature bug to compiler. @jaredpar as FYI

@VSadov VSadov self-assigned this May 10, 2016
@VSadov VSadov mentioned this issue May 11, 2016
Merged
VSadov added a commit to VSadov/roslyn that referenced this issue May 11, 2016
@VSadov
Make keyword recommender know about "replace"
b1524cb 
"replace" is roughly allowed in the same contexts as "async", so the "replace" ecommender is basically a copy of "async" recommender.

Fixes: dotnet#11191
@VSadov VSadov mentioned this issue May 12, 2016
Merged
@VSadov
Copy link
Member Author

VSadov commented May 12, 2016

It is actually fixed by the
#11231

@VSadov VSadov closed this as completed May 12, 2016
@VSadov VSadov added this to the Language Feature Merging milestone May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VSadov VSadov

Labels
Area-Compilers Bug Language-C# New Language Feature - Replace/Original Replace/Original
Projects
None yet
Milestone
Language Feature Merging
Development

No branches or pull requests
2 participants
@DustinCampbell @VSadov