Merging Features/generators into Future.

[VSadov]

Internal Dogfooding Requirements (Merge Signoff)

Critical IDE features in the areas of Typing, Navigating, and Viewing must function as expected. Any non-trivial issues in these areas blocking language feature merging.
All feature descriptions and testing suggestions are merely examples. Each language feature should be carefully considered independently against each IDE feature to find interesting intersections

Category	Feature/Description	C# Signoff/Notes	VB Signoff/Notes
Enable/Disable	Feature Flag Completely enables/disables the feature in the compiler & IDE	✅
Typing	General Typing - Type and paste new constructs - Nothing interferes with verbatim typing	✅ #11191 - Fixed
	Completion - Typing new keyword/construct names - Dotting off of new constructs	✅
	Formatting - Spacing in and around new constructs - Spacing options - Format Document command	✅
	Automatic Brace Completion (C# only) - Auto-insert close brace - Shift+Enter commit of pending brace completion	✅
	Indentation - Typing Enter in an unfinished statement indents the next line	✅
Navigating	Go To Definition - F12 from callsites to definition
	Go To Implementation - Jump from virtual members to their implementations - Jump from inheritable types to their implementations	✅
	Find All References - Lists references to a symbol in "Find Symbol Results" window - Shows results in hierarchy grouped by definition	🚧 #11192
Viewing	Colorization - Keywords, literals, and identifiers colored appropriately in code	✅
	Error Squiggles - Squiggles appear as expected on reasonable spans	✅

IDE Features (Feature Signoff)

For the remaining set of IDE features, only crashes and asserts are considered blocking. However, all issues discovered must be filed and linked here.
All feature descriptions and testing suggestions are merely examples. Each language feature should be carefully considered independently against each IDE feature to find interesting intersections

Code Transformations

Category	Feature/Description	C# Signoff/Notes	VB Signoff/Notes
Refactoring with UI	Inline Rename (with UI) - Dashboard shows correct information - Highlighted spans are updated appropriately - Rename operation updates the correct set of symbols	🚧 #11194
	Change Signature (with UI) - Updates all direct & cascaded definitions/callsites - Shows appropriate signature & parameter previews in UI	🚧 #11197
	Extract Interface (with UI) - Generated Interface has expected shape - UI shows appropriate method previews	✅ N/A ??
	Generate Type (with UI) - Dialog gives all valid options	✅ N/A ??
Refactorings	Rename Tracking - Tracking span tracks & dismisses as expected	✅
	Extract Method - Extracted method has the expected signature - All arguments/return values handled correctly - Extracted code block is reasonable	🚧 #11195
	Introduce Variable - Introduced variable has the expected signature and initializer expression - "Introduce for All" correctly finds dupes	✅
	Inline Temporary Variable - Inlined values are appropriately expanded/reduced	✅
	Organize Usings - Honors "Place 'System' namespace first" option	✅ N/A
	Convert "Get" Methods to Properties* Add Description	🚧 #11204
	Encapsulate Field Add Description	✅ N/A
Fixes	Add Using - Triggers on appropriate constructs	✅ N/A
	Generate Local Add Description	✅ N/A
	Generate Field Add Description	✅ N/A
	Generate Method/Constructor - Generated method has the expected signature and accessibility	✅ N/A
	Generate Constructor from members - Select fields/properties to generate a constructor accepting corresponding arguments - Generated constructor has the expected signature and accessibility	✅ N/A
	Implement Interface - Only missing methods added - All added methods have the expected signature and accessibility	✅
	Implement IDisposable Add Description	✅
	Implement Abstract Class Add Description	✅
Code Gen	Snippets Add Description	✅ N/A
	Event Hookup on Tab (C# only) - Type "+=" after an event name and QuickInfo shows - Invoking should pick good name & launch Inline Rename	✅ N/A	N/A
	End Construct Generation (VB only) Add Description	N/A
	Automatic End Construct Update (VB only) Add Description	N/A

IDE Features

Feature/Description	C# Signoff/Notes	VB Signoff/Notes
Signature Help - Overloads shown with appropriate, colorized signature	✅
Quick Info - Hover on identifiers - On completion list items	✅
Outlining Add Description	✅
Brace Matching (C# only) Add Description	✅	N/A
Highlight References Add Description	🚧 #11192
Peek Add Description	🚧 #11207
Navigation Bars Add Description	✅
Metadata As Source Add Description	✅ N/A
Navigate To Add Description	✅
Go to Next/Previous Method Add Description	✅
Solution Explorer Pivots Add Description	✅ N/A
Call Hierarchy Add Description	✅ N/A
Code Lens Add Description	✅
Project System Add Description	✅
Debugger IntelliSense Add Description	✅
Breakpoint Spans Add Description	✅
Code Model / Class Designer Add Description	✅
Object Browser / Class View Add Description	✅
Lightbulb Add Description	✅
Line Separators Add Description	✅
Options Add Description	✅

[VSadov]

@dotnet/roslyn-ide - FYI
@dotnet/roslyn-compiler - FYI

[VSadov]

I have also run @cston demo for NotifyPropertyChanged and it worked.

[gafter]