Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong matches highlighting in completion list if CompletionItem.FilterText is set #17969

Closed
vasily-kirichenko opened this issue Mar 19, 2017 · 9 comments
Assignees
Milestone

Comments

@vasily-kirichenko
Copy link

vasily-kirichenko commented Mar 19, 2017

If I create a CompletionItem with the following code:

CommonCompletionItem.Create(name, ..., filterText = filterText)

and filterText is different from name, then matches in completion list are wrong:

pasted image at 2017_03_19 18_41

(here filterText for items are bind, bind, BindIPEndPoint, bind2, bind and so on).

However, the filtering itself works OK.

I expect "bind" to be highlighted (shown in bold font) in all items. Currently it highlights the first four characters of each item.

@CyrusNajmabadi
Copy link
Member

What is your filter text in hte above examples?

@vasily-kirichenko
Copy link
Author

(here filterText for items are bind, bind, BindIPEndPoint, bind2, bind and so on).

In short, the last part of long (dot delemited) identifier. I'll recheck in debugger, but i'm pretty sure about that.

@CyrusNajmabadi
Copy link
Member

@vasily-kirichenko I have a potential fix. Can you try it out and see if it takes care of things for you?

@vasily-kirichenko
Copy link
Author

@CyrusNajmabadi sure, but how I can test it?

@CyrusNajmabadi
Copy link
Member

Just pull down my branch, and build Roslyn with it.

@Pilchie Pilchie added the Bug label Mar 20, 2017
@Pilchie Pilchie added this to the 15.3 milestone Mar 20, 2017
@CyrusNajmabadi
Copy link
Member

Ok, highlighting result with my change:

image

@vasily-kirichenko
Copy link
Author

This is great, thanks. How can I know that it's in NuGet?

@CyrusNajmabadi
Copy link
Member

This will be in our 15.3 release. If your work targets that same release, then things will work out. I'm not sure how/when this flows through nuget. @jasonmalinowski might know.

@jasonmalinowski
Copy link
Member

We will have packages uploaded https://dotnet.myget.org/gallery/roslyn that would contain the fix if you need it in NuGet package form. The packages would be versioned 2.3.0-beta1-*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants