-
Notifications
You must be signed in to change notification settings - Fork 4k
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong matches highlighting in completion list if CompletionItem.FilterText is set #17969
Comments
What is your filter text in hte above examples? |
In short, the last part of long (dot delemited) identifier. I'll recheck in debugger, but i'm pretty sure about that. |
@vasily-kirichenko I have a potential fix. Can you try it out and see if it takes care of things for you? |
@CyrusNajmabadi sure, but how I can test it? |
Just pull down my branch, and build Roslyn with it. |
This is great, thanks. How can I know that it's in NuGet? |
This will be in our 15.3 release. If your work targets that same release, then things will work out. I'm not sure how/when this flows through nuget. @jasonmalinowski might know. |
We will have packages uploaded https://dotnet.myget.org/gallery/roslyn that would contain the fix if you need it in NuGet package form. The packages would be versioned 2.3.0-beta1-*. |
If I create a
CompletionItem
with the following code:and
filterText
is different fromname
, then matches in completion list are wrong:(here
filterText
for items arebind
,bind
,BindIPEndPoint
,bind2
,bind
and so on).However, the filtering itself works OK.
I expect "bind" to be highlighted (shown in bold font) in all items. Currently it highlights the first four characters of each item.
The text was updated successfully, but these errors were encountered: