Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert workaround for AsyncSemaphore disposal problems #19042

Open
sharwell opened this issue Apr 27, 2017 · 4 comments
Open

Revert workaround for AsyncSemaphore disposal problems #19042

sharwell opened this issue Apr 27, 2017 · 4 comments
Assignees
@sharwell
Labels
Area-IDE Blocked Bug Concept-Continuous Improvement
Milestone
Backlog

Comments

@sharwell
Copy link
Member

sharwell commented Apr 27, 2017 •
edited

After we update Roslyn to a version of vs-threading which includes the change in microsoft/vs-threading#105, the workaround in pull request #19043 should be reverted.
@sharwell sharwell mentioned this issue Apr 27, 2017
Merged
sharwell added a commit to sharwell/roslyn that referenced this issue Apr 27, 2017
@sharwell
Add workaround for AsyncSemaphore disposal problems
d4a6431 
This is a workaround for dotnet#18563. See dotnet#19042 for a follow-up task to remove
this workaround.
@Pilchie
Copy link
Member

Pilchie commented Apr 29, 2017

When do we expect to update to a new version? Probably not before 15.3?

@Pilchie Pilchie added this to the 15.later milestone Apr 29, 2017
@sharwell
Copy link
Member Author

@Pilchie There is no expected update time frame yet. The upstream fix was closed as a tentative wontfix, so we'll see where things go.

@jinujoseph jinujoseph modified the milestones: 15.6, Unknown Nov 3, 2017
@CyrusNajmabadi
Copy link
Member

@sharwell still anything to do here? can we close this out if not?

@sharwell
Copy link
Member Author

sharwell commented Nov 7, 2022 •
edited

@CyrusNajmabadi The workaround can likely be removed now. The fix finally shipped in 16.3.

@CyrusNajmabadi CyrusNajmabadi modified the milestones: Backlog, 17.5 Nov 7, 2022
@arkalyanms arkalyanms modified the milestones: 17.5, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Blocked Bug Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@Pilchie @sharwell @CyrusNajmabadi @jinujoseph @arkalyanms