Go to implementation command, should view open source code

[ghost]

Version Used:
VS Community 15.5.1

Steps to Reproduce:
VS code editor has a "Go to implementation" context menu command. I suggest you allow this command to view the open source code of the requested Item. I need to look at the source code frequently, when documentations are poor to understand what is going on. The viewed source code should appear in VS as a code page, and contain a link to the gethub issues page to report any problems or suggestions.

Expected Behavior:
View the open source code.

Actual Behavior:
This sympole has no implementaions

Edit:
I'm talking about all. Net open source here in github. I was dealing with the Vector class. Documentsion is poor, and trying to open the html page for vector.cs here in github was a nightmare because it's huge. There is no link to download the source code of one class, or even a namespace. I only can download the CoreFX projec! So, I thought what if Vs.net code editor can browse to it directly, but it can't. This samll feather can integrate open source projects with Vs.net, encouraging developers to participate.

Github can provide a search request url that accepts the full name of a class and returns the link to opebn source file containing it. This way Vs.net code editor can download the requested file and view it, eather in design mode, or in debugging mode. It will be nice if you give us the ability to choose to trace the execution of this source code or just step over it. Also, the code page that results from the "Go to definition" command can have a "goto implementation" command to vieew the source code from there.

[CyrusNajmabadi]

I suggest you allow this command to view the open source code of the requested Item

This is how the feature works :)

This sympole has no implementaions

That's because we couldn't find any implementations. If we can't find any implementations there's no "source code of the requested item" we could "open" for you.

[jmarolf]

@MohammadHamdyGhanem I assume you want us to decompile the source if there is none to navigate to?

[jcouv]

I suspect the suggestion is that GoToImplementation should download the open-source code (from github or elsewhere on the web, determined somehow) and open that.
For example, if you use NewtonSoft's Json.NET as a nuget package, actual source (rather than decompiled source) should be opened when you invoke GoToImplementation.

I wonder if this is something that package/library authors can already achieve, either with source link or embedded source. It's possible that source link works when debugging, but not when simply editing.

[ghost]

Sorry if I was not clear. @jcouv made it crystal clear. I'm talking about all. Net open source here in github. I was dealing with the Vector class. Documentsion is poor, and trying to open the html page for vector.cs here in github was a nightmare because it's huge. There is no link to download the source code of one class, or even a namespace. I only can download the CoreFX projec! So, I thought what if Vs.net code editor can browse to it directly, but it can't. This samll feather can integrate open source projects with Vs.net, encouraging developers to participate.

[ghost]

I wonder if this is something that package/library authors can already achieve, either with source link or embedded source. It's possible that source link works when debugging, but not when simply editing.

Github can provide a search request url that accepts the full name of a class and returns the link to opebn source file containing it. This way Vs.net code editor can download the requested file and view it, eather in design mode, or in debugging mode. It will be nice if you give us the ability to choose to trace the execution of this source code or just step over it. Also, the code page that results from the "Go to definition" command can have a "goto implementation" command to vieew the source code from there.

[ghost]

@CyrusNajmabadi @jmarolf @jcouv @jinujoseph
Now that MS owns Github, it is easy to implement this command, and make it easier for us to jumb to the source code of any built-in class. Please do it.

[CyrusNajmabadi]

@MohammadHamdyGhanem I don't see what difference it makes if MS owns Github.

[ufcpp]

SourceLink?

[jinujoseph]

cc @tmat

[jcouv]

Yes, this should work with SourceLink now. This should be done by individual package owners.

[ghost]

@CyrusNajmabadi
You didn't get my idea till now. Suppose I'm using System.Math.Round() and want to look to its source code. Instead of searching githup, I want to right-click the Round Method in my code, and click Go to Implementation to open the source code dirctly in a new tab in Vs.net, have all the editor support and tool tips, even set break points! When I first asked for it, maybe it was difficult to get support from githup, but now MS can do any necessary changes to github it self to make it easy to send a reguest with just a full qualified method name to navigate directly to its source without making any change in the. Net source code itself.

[sharwell]

Duplicate of #24349

[ghost]

@sharwell
This is different. #24349 wants to decompile the assebly, and I want to get the code from Github source code.

[sharwell]

@MohammadHamdyGhanem Prior to attempting to decompile, that issue says we should attempt to locate and use the original source code when possible. This includes but isn't limited to sources linked to GitHub.

[jmarolf]

@MohammadHamdyGhanem see here and here. I believe what you want is for all the .NET assemblies that Microsoft ships to support SourceLink. @tmat I believe SourceLink is used automatically now for all .NET Core builds correct?

[tmat]

Yes.

[tmat]

@jmarolf BTW, corrected Source Link link in your comment to: http://github.com/dotnet/sourcelink

[sharwell]

@jmarolf Note that SourceLink currently only supports debugging scenarios. It doesn't help the normal editing experience scenarios suggested in this issue at all.

[tmat]

@sharwell Currently. There is no reason it couldn't be used outside of debugging session.