Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect: Cannot disable automatic indenting in Pretty Listing #2509

Open
dotnet-bot opened this issue May 5, 2015 · 8 comments
Open

Connect: Cannot disable automatic indenting in Pretty Listing #2509

dotnet-bot opened this issue May 5, 2015 · 8 comments
Assignees
@mattwar
Labels
Area-IDE Bug IDE-Formatter Code formatter and/or smart indent
Milestone
Backlog

Comments

@dotnet-bot
Copy link
Collaborator

Ported from TFS WorkItem: 1152246

Repro Steps:

Even with automatic indenting disabled, if you enable Pretty Listing to adjust spacing and capitalization, it also adjusts the indenting, ignoring (in addition to it being disiabled) the tab sizes. It should be separate as it is in VS2008.

vb.net

Revisions:

  1. Created By Microsoft Connect (4/5/2015 11:52:18 PM)

------------------------

Customer Information

------------------------

User ID: 14783669

Handle: xpda



---------------------------

Connect Site Information

---------------------------

Site Name: Visual Studio and .NET Framework

Site ID: 210

Feedback ID: 1228645

Feedback Form: 5975



----------------------

Problem Description

-----------------------

Even with automatic indenting disabled, if you enable Pretty Listing to adjust spacing and capitalization, it also adjusts the indenting, ignoring (in addition to it being disiabled) the tab sizes. It should be separate as it is in VS2008.

vb.net

  1. Edited By Macy Qu (Shang Hai Wei Chuang Ruan Jian) (4/6/2015 10:28:38 PM)

repro on win8.1 with VS2015 Preview

  1. Edited By Kevin Pilch-Bisson (4/7/2015 8:22:35 AM)

Do you think this is important to preserve?
@dotnet-bot dotnet-bot added this to the 1.0 (stable) milestone May 5, 2015
basoundr added a commit to basoundr/roslyn that referenced this issue May 5, 2015
@basoundr
FormatEngine honors IndentationStyle during LineOp
f0445f5 
Fix dotnet#2509 FormatEngine should honor the user selected IndentationStyle
option while performing Line Operation
@basoundr basoundr mentioned this issue May 5, 2015
Closed
basoundr added a commit to basoundr/roslyn that referenced this issue May 5, 2015
@basoundr
FormatEngine honors IndentationStyle during LineOp
43362e0 
Fix dotnet#2509 FormatEngine should honor the user selected IndentationStyle
option while performing Line Operation
@Pilchie Pilchie assigned mattwar and unassigned basoundr May 8, 2015
@mattwar
Copy link
Contributor

mattwar commented Jun 3, 2015

I'm looking for more clarification on the extent of the expected behavior.

@AdamSpeight2008
Copy link
Contributor

@mattwar My suspect would NormaliseWhitespace not respecting the options.

@mattwar
Copy link
Contributor

mattwar commented Jun 3, 2015

NormalizeWhitespace doesn't respect any options. It's purpose is to make the tree round trip correctly into text and back into a similar tree. It's formatting behavior is hardcoded.

This bug is about experience of VB source file while editing in VS. NormalizeWhitespace is not used for this.

@DustinCampbell DustinCampbell modified the milestones: 1.1, 1.0 (stable) Jun 8, 2015
@PatriceDargenton
Copy link

Will this issue be fixed in the next VS 2015 update ?

@Pilchie
Copy link
Member

Pilchie commented Sep 19, 2015

That's the current plan, assuming we don't run out of time.

@PatriceDargenton
Copy link

Ok, thanks.

@Pilchie Pilchie modified the milestones: 1.2, 1.1 Oct 15, 2015
@PatriceDargenton
Copy link

Visual Studio Community 2015 Update 1 CTP : The bug is still there... I will wait for update 2 so...

@DustinCampbell DustinCampbell modified the milestones: 1.3, 1.2 Feb 23, 2016
@PatriceDargenton
Copy link

Visual Studio Community 2015 Update 2 : The bug is still there ! :-(

@Pilchie Pilchie modified the milestones: 2.0 (RC), 1.3 May 27, 2016
@Pilchie Pilchie modified the milestones: 2.0 (Preview 5), 2.0 (RC) Sep 26, 2016
@Pilchie Pilchie added this to the 2.0 (RTM) milestone Nov 2, 2016
@Pilchie Pilchie removed this from the 2.0 (RC) milestone Nov 2, 2016
@Pilchie Pilchie modified the milestones: 3.0, 2.0 (RTM) Jan 19, 2017
@jinujoseph jinujoseph modified the milestones: 16.0, Backlog Jan 21, 2019
@CyrusNajmabadi CyrusNajmabadi added the IDE-Formatter Code formatter and/or smart indent label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattwar mattwar

Labels
Area-IDE Bug IDE-Formatter Code formatter and/or smart indent
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

FormatEngine honors IndentationStyle during LineOp basoundr/roslyn
9 participants
@DustinCampbell @Pilchie @AdamSpeight2008 @mattwar @CyrusNajmabadi @dotnet-bot @basoundr @jinujoseph @PatriceDargenton