Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to preserve val escape for recursive pattern-matching #28633

Closed
gafter opened this issue Jul 18, 2018 · 3 comments
Closed

Need to preserve val escape for recursive pattern-matching #28633

gafter opened this issue Jul 18, 2018 · 3 comments
Assignees
@gafter
Labels
Area-Compilers Bug
Milestone
16.0

Comments

@gafter
Copy link
Member

gafter commented Jul 18, 2018

Recursive pattern matching does not compute the val escape for pattern variables in the recursive patterns branch.
@gafter gafter added this to the 16.0 milestone Jul 18, 2018
@gafter gafter self-assigned this Jul 18, 2018
@gafter
Copy link
Member Author

gafter commented Jul 18, 2018

This was fixed in master for declaration patterns in #27218 but that solution does not simply generalize to recursive patterns.

@gafter gafter mentioned this issue Aug 8, 2018
Closed
@gafter
Copy link
Member Author

gafter commented Aug 8, 2018

We need to port #27803 to the features/recursive-patterns branch and extend it to all the other pattern-matching forms.

@gafter gafter moved this from Next Up to Working/In Review in Compiler: Pattern-Matching Aug 8, 2018
gafter added a commit to gafter/roslyn that referenced this issue Aug 9, 2018
@gafter
Compute val escape for pattern-matching
9cf5223 
Fixes dotnet#28633
@gafter gafter mentioned this issue Aug 9, 2018
Merged
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label Aug 9, 2018
gafter pushed a commit that referenced this issue Aug 17, 2018
Compute val escape for recursive pattern-matching (#29188)
9d5bd87 
Fixes #28633
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label Aug 17, 2018
@gafter
Copy link
Member Author

gafter commented Aug 17, 2018

Fixed in #29188

@gafter gafter closed this as completed Aug 17, 2018
@gafter gafter removed this from Working/In Review in Compiler: Pattern-Matching Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
1 participant
@gafter