Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy escape scope of pattern locals from source expressions #27803

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Copy escape scope of pattern locals from source expressions #27803

merged 2 commits into from
Jun 14, 2018

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Jun 13, 2018 •
edited
Loading

Fixes #27218

@OmarTawfik OmarTawfik added this to the 15.8 milestone Jun 13, 2018
@OmarTawfik OmarTawfik requested a review from a team as a code owner June 13, 2018 21:28
@OmarTawfik
Copy link
Contributor Author

@dotnet/roslyn-compiler this is ready for review.

333fred
333fred approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

gafter
gafter approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@OmarTawfik OmarTawfik mentioned this pull request Jun 14, 2018
Closed
This was referenced Jun 14, 2018
Closed
Closed
@OmarTawfik
Copy link
Contributor Author

OmarTawfik commented Jun 14, 2018 •
edited
Loading

@dotnet/roslyn-infrastructure @dotnet/dnceng for transient failures (first, second)
System.Runtime.Remoting.RemotingException : Failed to write to an IPC Port: The pipe is being closed.

@OmarTawfik
Copy link
Contributor Author

@jcouv for merge approval

@jcouv
Copy link
Member

jcouv commented Jun 14, 2018

Approved to merge

@OmarTawfik OmarTawfik merged commit 82fa409 into dotnet:master Jun 14, 2018
@OmarTawfik OmarTawfik deleted the bugs/27218/ref-return-current-stack branch June 14, 2018 20:00
@gafter gafter mentioned this pull request Aug 8, 2018
Closed
@gafter gafter mentioned this pull request Dec 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@gafter gafter gafter approved these changes

Assignees
No one assigned
Labels
Approved to merge Area-Compilers Bug
Projects
None yet
Milestone
15.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OmarTawfik @jcouv @333fred @gafter