Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a refactoring to convert conditional to if statement #29346

Open
AndriySvyryd opened this issue Aug 16, 2018 · 5 comments
Open

Add a refactoring to convert conditional to if statement #29346

AndriySvyryd opened this issue Aug 16, 2018 · 5 comments
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@AndriySvyryd
Copy link
Member

This would be the reverse of IDE0046 for users that prefer if statements.

Also consider making it a setting in .editorconfig

@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Aug 16, 2018

  1. I'm definitely supportive of hte refactoring to convert conditional-to-if.
  2. I'm more wary of the idea of this being .editorconfig. I don't think i'd really want to support an option saying: you can't use conditionals and you must use if-statements.

@jinujoseph jinujoseph added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-IDE Feature Request labels Aug 16, 2018
@jinujoseph jinujoseph added this to the Unknown milestone Aug 16, 2018
@tokarzkj
Copy link
Contributor

tokarzkj commented Sep 5, 2018

I would be interested in working on this if no one has started on it. It is my first time contributing to the project and seems like a good introduction.

@jinujoseph
Copy link
Contributor

Sure , Go for it @tokarzkj
cc @heejaechang as your buddy to help out if you have questions.

@CyrusNajmabadi
Copy link
Member

@tokarzkj I'd recommend holding off on this until #28768 goes in. Because this new refactoring of the current analyzer/fix that is in the product, it would be good if that dependent PR goes in as it will help force the appropriate shape for the refactoring you'd provide.

@tokarzkj
Copy link
Contributor

tokarzkj commented Sep 6, 2018

@CyrusNajmabadi - Thanks for the heads up! I will wait for that PR before beginning my work then.

@jmarolf jmarolf added the User Story A single user-facing feature. Can be grouped under an epic. label Dec 2, 2021
@jmarolf jmarolf removed the User Story A single user-facing feature. Can be grouped under an epic. label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

No branches or pull requests

5 participants