New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssemblyInformationalVersionAttribute fails on SemVer2 strings #35793
Comments
The issue might be in |
Is this a regression or is that always how informational version in this form was handled? Do we need to be concerned about a breaking change here? |
This is how csc always worked. It didn't account for SemVer2. But there is no spec for parsing AIV, so we do best effort. We just looked at it with @jcouv and we think we can fix the compiler. |
Not urgent. I don't see how this is more than a trivial to fix bug though. |
Works around dotnet/roslyn#35793 which sets a win32 resource to a bad value when there are too many dots in `AssemblyInformationalVersion`. Medium term, I'd rather see us on semver2, since it's a nicer overall experience.
Works around dotnet/roslyn#35793 which sets a win32 resource to a bad value when there are too many dots in `AssemblyInformationalVersion`.
FWIW, this is causing me a ton of pain because I can't build from VS command prompt. Is there a fix in sight? |
@DustinCampbell It should be a matter of having an arcade with this change: dotnet/arcade#2825 Is that not already the case? |
@DustinCampbell Should be merged to Roslyn repo now. What repo are you working with? |
https://github.com/dotnet/winforms-designer. Maybe we just took the update? Will try again this morning. Update: This does work today. |
Version Used:
3.100.19.22309 (ce8ac3f7)
Steps to Reproduce:
Expected Behavior:
This appears to be what you get if you have too many dots in the pre-release version section (after the dash). For instance, this works:
but this does not:
Actual Behavior:
This manifests more importantly as a failure in
Which is how it was reported to MSBuild after the first Arcade + semver2 MSBuild builds rolled out into internal VS channels.
The text was updated successfully, but these errors were encountered: