Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params arrays should be created during binding #49602

Closed
RikkiGibson opened this issue Nov 24, 2020 · 0 comments · Fixed by #70762
Closed

Params arrays should be created during binding #49602

RikkiGibson opened this issue Nov 24, 2020 · 0 comments · Fixed by #70762
Assignees
@AlekseyTs
Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Milestone
17.9

Comments

@RikkiGibson
Copy link
Contributor

Related to #47352

If we change handling of params arrays to simply create the params array during binding, as VB does, it will simplify a lot of things for consumers. For example, it will make it easier for flow analysis to just do the right thing with params arrays, instead of everything having to check an 'expanded' flag and handle it, since it will simply receive bound nodes whose structure reflects the language semantics.

/cc @AlekseyTs
@RikkiGibson RikkiGibson added Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Nov 24, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 24, 2020
@RikkiGibson RikkiGibson self-assigned this Nov 24, 2020
@RikkiGibson RikkiGibson added this to the 16.9 milestone Nov 24, 2020
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 1, 2020
@jaredpar jaredpar modified the milestones: 16.9, Compiler.Next Apr 26, 2021
@RikkiGibson RikkiGibson mentioned this issue May 14, 2021
Open
@RikkiGibson RikkiGibson mentioned this issue Jul 22, 2022
Merged
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
@AlekseyTs AlekseyTs self-assigned this Nov 6, 2023
@jaredpar jaredpar modified the milestones: Backlog, 17.9 Nov 6, 2023
@AlekseyTs AlekseyTs mentioned this issue Nov 10, 2023
Open
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Nov 10, 2023
@AlekseyTs
Create params arrays during binding
663d153 
Closes dotnet#49602.
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Nov 10, 2023
@AlekseyTs
Create params arrays during binding
53fd600 
Closes dotnet#49602.
@AlekseyTs AlekseyTs mentioned this issue Nov 10, 2023
Merged
AlekseyTs added a commit that referenced this issue Nov 14, 2023
@AlekseyTs
Create params arrays during binding (#70762)
31bb536 
Closes #49602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Milestone
17.9
Development

Successfully merging a pull request may close this issue.

Create params arrays during binding AlekseyTs/roslyn
4 participants
@jaredpar @RikkiGibson @AlekseyTs @Dotnet-GitSync-Bot