Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixAllOccurrencesIgnoresGeneratedCode is flaky #56625

Open
Cosifne opened this issue Sep 22, 2021 · 7 comments
Open

FixAllOccurrencesIgnoresGeneratedCode is flaky #56625

Cosifne opened this issue Sep 22, 2021 · 7 comments
Assignees
@sharwell
Labels
Area-IDE Area-Infrastructure Flaky Infraswat Integration-Test Test failures in roslyn-integration-CI Urgency-Soon
Milestone
Backlog

Comments

@Cosifne
Copy link
Member

Cosifne commented Sep 22, 2021 •
edited by runfoapp bot

Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=1653816&view=results
Example error messages:

System.Exception : No light bulb session in View! Buffer content type=CSharp

System.MissingMethodException : Method not found: 'Microsoft.VisualStudio.Threading.JoinableTaskContext Microsoft.VisualStudio.Shell.ThreadHelper.get_JoinableTaskContext()'.

Runfo Tracking Issue: [Roslyn][Flaky test] CSharp.CSharpCodeActions.FixAllOccurrencesIgnoresGeneratedCode

Build Definition Kind Run Name
624935 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True
624935 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True
624935 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True
624551 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True
624551 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True
624551 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True
624420 roslyn-integration-CI PR 72790 1-Integration Debug OOP64_True OOPCoreClr_False
624420 roslyn-integration-CI PR 72790 1-Integration Debug OOP64_True OOPCoreClr_False
624420 roslyn-integration-CI PR 72790 1-Integration Debug OOP64_True OOPCoreClr_False
624376 roslyn-integration-CI PR 72293 1-Integration Debug OOP64_True
624376 roslyn-integration-CI PR 72293 1-Integration Debug OOP64_True
624376 roslyn-integration-CI PR 72293 1-Integration Debug OOP64_True
624250 roslyn-integration-CI PR 71268 1-Integration Debug OOP64_True
624250 roslyn-integration-CI PR 71268 1-Integration Debug OOP64_True
624250 roslyn-integration-CI PR 71268 1-Integration Debug OOP64_True
624021 roslyn-integration-CI PR 72792 1-Integration Debug OOP64_True
624021 roslyn-integration-CI PR 72792 1-Integration Debug OOP64_True
624021 roslyn-integration-CI PR 72792 1-Integration Debug OOP64_True
623548 roslyn-integration-CI PR 72797 1-Integration Debug OOP64_True OOPCoreClr_False
623548 roslyn-integration-CI PR 72797 1-Integration Debug OOP64_True OOPCoreClr_False
623548 roslyn-integration-CI PR 72797 1-Integration Debug OOP64_True OOPCoreClr_False
623450 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
623450 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
623450 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
623450 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
623450 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
623450 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
623412 roslyn-integration-CI PR 72783 1-Integration Debug OOP64_True
623412 roslyn-integration-CI PR 72783 1-Integration Debug OOP64_True
623412 roslyn-integration-CI PR 72783 1-Integration Debug OOP64_True
623047 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
623047 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
623047 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
622617 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
622617 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
622617 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
622563 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
622563 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
622563 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
621802 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
621802 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
621802 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
621563 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
621563 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
621563 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
621407 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
621407 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
621407 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
620917 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
620917 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
620917 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
620880 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
620880 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
620880 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
620103 roslyn-integration-CI PR 72739 1-Integration Debug OOP64_True OOPCoreClr_False
620103 roslyn-integration-CI PR 72739 1-Integration Debug OOP64_True OOPCoreClr_False
620103 roslyn-integration-CI PR 72739 1-Integration Debug OOP64_True OOPCoreClr_False
619654 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
619654 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
619654 roslyn-integration-CI PR 72654 1-Integration Debug OOP64_True OOPCoreClr_False
619123 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
619123 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
619123 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
619123 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
619123 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
619123 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
619083 roslyn-integration-CI PR 72737 1-Integration Release OOP64_False OOPCoreClr_False
619083 roslyn-integration-CI PR 72737 1-Integration Release OOP64_False OOPCoreClr_False
619083 roslyn-integration-CI PR 72737 1-Integration Release OOP64_False OOPCoreClr_False
619083 roslyn-integration-CI PR 72737 1-Integration Debug OOP64_True OOPCoreClr_False
619083 roslyn-integration-CI PR 72737 1-Integration Debug OOP64_True OOPCoreClr_False
619083 roslyn-integration-CI PR 72737 1-Integration Debug OOP64_True OOPCoreClr_False
618929 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618929 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618929 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618824 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618824 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618824 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618369 roslyn-integration-CI PR 72730 1-Integration Debug OOP64_True OOPCoreClr_False
618369 roslyn-integration-CI PR 72730 1-Integration Debug OOP64_True OOPCoreClr_False
618369 roslyn-integration-CI PR 72730 1-Integration Debug OOP64_True OOPCoreClr_False
618211 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618211 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618211 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
618041 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
618041 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
618041 roslyn-integration-CI Rolling 1-Integration Debug OOP64_True OOPCoreClr_False
617985 roslyn-integration-CI PR 72296 1-Integration Debug OOP64_True OOPCoreClr_False
617985 roslyn-integration-CI PR 72296 1-Integration Debug OOP64_True OOPCoreClr_False
617985 roslyn-integration-CI PR 72296 1-Integration Debug OOP64_True OOPCoreClr_False
617666 roslyn-integration-CI PR 72296 1-Integration Debug OOP64_True OOPCoreClr_False
617666 roslyn-integration-CI PR 72296 1-Integration Debug OOP64_True OOPCoreClr_False
617666 roslyn-integration-CI PR 72296 1-Integration Debug OOP64_True OOPCoreClr_False
617440 roslyn-integration-CI PR 72723 1-Integration Debug OOP64_True OOPCoreClr_False
617440 roslyn-integration-CI PR 72723 1-Integration Debug OOP64_True OOPCoreClr_False
617440 roslyn-integration-CI PR 72723 1-Integration Debug OOP64_True OOPCoreClr_False
616714 roslyn-integration-CI PR 72708 1-Integration Debug OOP64_True OOPCoreClr_False
616714 roslyn-integration-CI PR 72708 1-Integration Debug OOP64_True OOPCoreClr_False
616714 roslyn-integration-CI PR 72708 1-Integration Debug OOP64_True OOPCoreClr_False
616708 roslyn-integration-CI PR 72613 1-Integration Debug OOP64_True OOPCoreClr_False

Displaying 100 of 114 results

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@Cosifne Cosifne added Area-IDE Integration-Test Test failures in roslyn-integration-CI labels Sep 22, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 22, 2021
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 29, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Sep 29, 2021
@sharwell
Copy link
Member

Probable cause is integration tests are not waiting for async light bulb to show all items

@sharwell sharwell modified the milestones: 17.0, 17.1 Sep 29, 2021
@CyrusNajmabadi
Copy link
Member

@sharwell same question. Do you still think this is async lightbulbs? And, if so, are yous till seeing this?

@sharwell
Copy link
Member

I'm not sure on the status of this one

@CyrusNajmabadi CyrusNajmabadi modified the milestones: 17.1, 17.2 Dec 16, 2021
@CyrusNajmabadi CyrusNajmabadi removed their assignment Dec 16, 2021
@333fred 333fred mentioned this issue Mar 1, 2022
Merged
@allisonchou
Copy link
Contributor

This test is still flaky; updating the RunFo query momentarily to reflect this.

@runfoapp runfoapp bot removed this from the 17.2 milestone Mar 9, 2022
@runfoapp runfoapp bot closed this as completed Mar 9, 2022
@allisonchou allisonchou reopened this Mar 9, 2022
@runfoapp runfoapp bot closed this as completed Mar 9, 2022
@allisonchou allisonchou reopened this Mar 9, 2022
@allisonchou
Copy link
Contributor

@CyrusNajmabadi @sharwell we're still seeing this issue in newer builds. Is this an issue with async lightbulbs?

@sharwell
Copy link
Member

@allisonchou Yes, this is known. It should be fixed by #60048 , but that is blocked on some other prerequisites.

@jcouv
Copy link
Member

jcouv commented Mar 17, 2022

Assigned to @sharwell since he seems to be working on a fix. Thanks

@jcouv jcouv added this to the 17.2 milestone Mar 17, 2022
@arkalyanms arkalyanms modified the milestones: 17.2, 17.5, 17.5 P1 Oct 3, 2022
@arkalyanms arkalyanms modified the milestones: 17.5, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Area-Infrastructure Flaky Infraswat Integration-Test Test failures in roslyn-integration-CI Urgency-Soon
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@sharwell @CyrusNajmabadi @jinujoseph @jcouv @allisonchou @Cosifne @arkalyanms