Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary components from devcontainer #59825

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Mar 1, 2022

We had some things in the devcontainer that are necessary for the runtime repo, but not for roslyn.

@333fred 333fred requested a review from a team as a code owner March 1, 2022 00:55
@333fred 333fred requested a review from jmarolf March 1, 2022 00:55
@333fred
Copy link
Member Author

333fred commented Mar 1, 2022

@jmarolf for review.

We had some things in the devcontainer that are necessary for the runtime repo, but not for roslyn.
@333fred 333fred removed the request for review from a team March 1, 2022 00:57
@333fred 333fred changed the title update devcontainer Remove unnecessary components from devcontainer Mar 1, 2022
@333fred 333fred enabled auto-merge (squash) March 1, 2022 18:29
@333fred
Copy link
Member Author

333fred commented Mar 1, 2022

Correctness_Rebuild succeeded, the hook is just stuck: https://dev.azure.com/dnceng/public/_build/results?buildId=1637015&view=logs&jobId=85c53086-d585-50b3-ae0b-d040c710cd82
Integration CI Failures: #56625 and #59855

@333fred 333fred disabled auto-merge March 1, 2022 21:36
@333fred 333fred merged commit d9261bc into dotnet:main Mar 1, 2022
@ghost ghost added this to the Next milestone Mar 1, 2022
@333fred 333fred deleted the update-devcontainer branch March 1, 2022 21:36
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants